Pinging @elastic/es-analytics-geo (:Analytics/Aggregations)

@imotov What do you want to do with this? As you say, it's currently stuck on SQL's formatting behavior, which, honestly, I'm not sure how that was working before. The code I'm using here is taken directly from the field formatter, so I'm shocked it wasn't throwing from there before. Do you want to fix this SQL side and I'll pull the fix in here and see what we have?

Alternatively, I can change this to accept and ignore a timezone, which should get the tests passing. I don't love ignoring parameters, it seems excessively lenient, but it wouldn't be worse than it is now.

I have done some digging. Here is the reproduction of the issue that doesn't involve SQL:

DELETE test
PUT test
{
  "mappings": {
    "properties": {
      "start": {
        "type": "date"
      }
    }
  }
}

PUT test/_doc/1
{
  "start": "2020-01-01T00:00:00"
}

PUT test/_doc/2
{
  "start": "2020-01-02T00:00:00"
}

POST test/_search
{
  "aggs": {
    "agg1": {
      "date_histogram": {
        "script": {
          "source": "doc['start'].value"
        },
        "calendar_interval": "1y",
        "value_type": "long",
        "time_zone" : "-04"
      }
    }
  }
}

That works without this PR and I feel like it is a valid use-case and it should work. I think we are again dealing with overloaded parameters here.

@elasticmachine update branch

@elasticmachine test this please

@elasticmachine update branch

@elasticmachine update branch