[DOCS] Reformat flatten_graph token filter#54268
[DOCS] Reformat flatten_graph token filter#54268jrodewig merged 3 commits intoelastic:masterfrom jrodewig:docs__reformat-flatten-graph-tokenfilter
flatten_graph token filter#54268Conversation
Makes the following changes to the `flatten_graph` token filter docs: * Rewrites description and adds Lucene link * Adds detailed analyze example * Adds analyzer example
|
Pinging @elastic/es-docs (>docs) |
|
Pinging @elastic/es-search (:Search/Analysis) |
romseygeek
left a comment
There was a problem hiding this comment.
Thanks @jrodewig . I think we need to more actively discourage people from using this filter, as it's a not-very-good solution for a problem that should be fixed by doing things at query time instead.
| If possible, avoid using graph token filters in | ||
| <<analysis-index-search-time,index analyzers>>. Use the respective | ||
| <<analysis-synonym-tokenfilter,`synonym`>> or | ||
| <<analysis-word-delimiter-tokenfilter,`word_delimiter`>> filters instead. |
There was a problem hiding this comment.
I think it would be good to reword this to strongly advise against using these at index time at all - generally speaking, filters that could produce graphs should be used at query time instead. flatten_graph is a kind of shonky workaround for a problem that really should be fixed elsewhere.
There was a problem hiding this comment.
Thanks for the feedback @romseygeek!
With afcbebf, I reworded the warning to remove the recommendation for the synonym and word_delimiter filters. It also recommends that token graph filters only be used in search analyzers.
Let me know if you see any other needed changes!
romseygeek
left a comment
There was a problem hiding this comment.
LGTM, thanks @jrodewig
|
Thanks @romseygeek. |
* [DOCS] Reformat `flatten_graph` token filter Makes the following changes to the `flatten_graph` token filter docs: * Rewrites description and adds Lucene link * Adds detailed analyze example * Adds analyzer example
* [DOCS] Reformat `flatten_graph` token filter Makes the following changes to the `flatten_graph` token filter docs: * Rewrites description and adds Lucene link * Adds detailed analyze example * Adds analyzer example
* [DOCS] Reformat `flatten_graph` token filter Makes the following changes to the `flatten_graph` token filter docs: * Rewrites description and adds Lucene link * Adds detailed analyze example * Adds analyzer example
Makes the following changes to the
flatten_graphtoken filter docs: