Skip to content

Explicitly set mappings in SearchAfterIT#54262

Merged
romseygeek merged 1 commit intoelastic:masterfrom
romseygeek:bugfix/searchafterit
Mar 26, 2020
Merged

Explicitly set mappings in SearchAfterIT#54262
romseygeek merged 1 commit intoelastic:masterfrom
romseygeek:bugfix/searchafterit

Conversation

@romseygeek
Copy link
Copy Markdown
Contributor

We have some very occasional failures in SearchAfterIT, where a search throws
an exception because the shard does not have a mapping for the requested sort
field. The field should have been added in a dynamic mapping update after an
index event, but it seems that there can sometimes be a small delay in propagating
this update to the shards.

This commit changes the test to explicitly define the relevant field at index creation
time.

Fixes #51900

@romseygeek romseygeek added >test Issues or PRs that are addressing/adding tests :Search Foundations/Mapping Index mappings, including merging and defining field types v8.0.0 v7.8.0 labels Mar 26, 2020
@romseygeek romseygeek requested a review from jimczi March 26, 2020 12:03
@romseygeek romseygeek self-assigned this Mar 26, 2020
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-search (:Search/Mapping)

Copy link
Copy Markdown
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @romseygeek

@romseygeek romseygeek merged commit a56da21 into elastic:master Mar 26, 2020
@romseygeek romseygeek deleted the bugfix/searchafterit branch March 26, 2020 13:06
romseygeek added a commit that referenced this pull request Mar 26, 2020
We have some very occasional failures in SearchAfterIT, where a search throws
an exception because a shard does not have the mapping for the requested sort
field. The field should have been added in a dynamic mapping update after an
index event, but it seems that there can sometimes be a small delay in propagating
this update to the shards.

This commit changes the test to explicitly define the relevant field at index creation
time.

Fixes #51900
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Search Foundations/Mapping Index mappings, including merging and defining field types >test Issues or PRs that are addressing/adding tests v7.8.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SearchAfterIT.testsShouldFail failure on CI

4 participants