transform.cat should live in the cat namespace.#54196
Merged
Mpdreamz merged 2 commits intoelastic:masterfrom Mar 25, 2020
Merged
transform.cat should live in the cat namespace.#54196Mpdreamz merged 2 commits intoelastic:masterfrom
Mpdreamz merged 2 commits intoelastic:masterfrom
Conversation
Similarly to to ml cat API's also living in the `cat` namespace. Clients treat the `cat` namespace differently then other API's (return types, content types). This introduces an exception to this rule.
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/REST API) |
droberts195
reviewed
Mar 25, 2020
x-pack/plugin/src/test/resources/rest-api-spec/api/transform.cat_transform.json
Show resolved
Hide resolved
|
I marked this |
Collaborator
|
Pinging @elastic/ml-core (:ml/Transform) |
droberts195
approved these changes
Mar 25, 2020
droberts195
left a comment
There was a problem hiding this comment.
LGTM
Thanks for noticing and fixing the discrepancy!
benwtrent
approved these changes
Mar 25, 2020
Mpdreamz
added a commit
that referenced
this pull request
Mar 25, 2020
* transform.cat should live in the cat namespace. Similarly to to ml cat API's also living in the `cat` namespace. Clients treat the `cat` namespace differently then other API's (return types, content types). This introduces an exception to this rule. * rename the specification file as well (cherry picked from commit 0a98904)
Mpdreamz
added a commit
that referenced
this pull request
Mar 25, 2020
* transform.cat should live in the cat namespace. Similarly to to ml cat API's also living in the `cat` namespace. Clients treat the `cat` namespace differently then other API's (return types, content types). This introduces an exception to this rule. * rename the specification file as well (cherry picked from commit 0a98904)
Member
Author
|
Thanks for the reviews @droberts195 @benwtrent 👍 |
This was referenced Mar 25, 2020
38 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similarly to to
mlcat API's also living in thecatnamespace.Clients treat the
catnamespace differently then other API's (return types, content types). This fixes the exception to this rule.