Fix StackOverflowError in CheckStyle for CRUDDocumentationIT#53840
Fix StackOverflowError in CheckStyle for CRUDDocumentationIT#53840original-brownbear merged 1 commit intoelastic:masterfrom original-brownbear:37647
Conversation
This file seems to randomly cause a stack overflow like other HLRC ITs that already have this check suppressed on them. Closes #37647
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
mark-vieira
left a comment
There was a problem hiding this comment.
I'm a bit confused, are we really suppressing that snippet length check on basically al the high level rest client documentation tests? If so, what's the point of the check? It is specifically to ensure that docs snippets are not more than a certain length so they'll render correctly in the docs but we are turning this off everywhere?
|
Wow. I uh, don't remember doing this before. I probably did do it because past me is pretty silly. I think this regex was a mistake. I thought so when I wrote it but I figured it was an ok mistake. But, bleh. |
|
@mark-vieira @nik9000 maybe we can still move ahead with this and fix it properly for all the excluded doc ITs separately? This is quite annoying for me locally :D That said: |
mark-vieira
left a comment
There was a problem hiding this comment.
I'm good with merging this for now to unblock folks so long as we open an issue to get this check working again.
|
Thanks Mark! I opened #53921 to track this. |
This file seems to randomly cause a stack overflow like other HLRC ITs that
already have this check suppressed on them.
Closes #37647