EQL: Extract query folder tests definitions into resources#53802
EQL: Extract query folder tests definitions into resources#53802aleksmaus merged 1 commit intoelastic:masterfrom
Conversation
|
Pinging @elastic/es-search (:Search/EQL) |
724e772 to
2ffa9cf
Compare
imotov
left a comment
There was a problem hiding this comment.
I really like where it is going, and I understand that this is just a string comparison at the moment. However, I wonder if it is possible to make the testing expressions a bit more JSON-like and make it not rely on the order of fields in JSON objects.
One idea would be to just put json parse it into a map and make sure this it is "submap" of the response. So basically something like {"foo": {"baz":2"}} would match response {"foo": {"bar": 1, "baz":2"}}.
There was a problem hiding this comment.
These unclosed parentheses are tearing holes in my OCD soul. 😄
|
What's the motivation? |
|
2ffa9cf to
fed316d
Compare
|
Rebased against the latest master to resolve the conflicts and force pushed. |
|
@aleksmaus Use merging instead of rebase to preserve history. |
| "\"term\":{\"opcode\":{\"value\":3", | ||
| } | ||
| }, | ||
| {"substringFunction", "process where substring(file_name, -4) == '.exe'", |
There was a problem hiding this comment.
This test was skipped during externalization. Discovered that during backporting - I'm working on fixing it in master and 7.x
@costin, this addresses the other ask that you had for extracting the tests specs into resources.
As far as I understood we were talking about simple text file, but can change the format however needed. Let me know.