EQL: EqlActionIT improvements#53780
Conversation
There was a problem hiding this comment.
@costin I was not sure what to put in here, but now looks like I need these files for jtoml dependency verification task in EQL QA project.
let me know.
There was a problem hiding this comment.
If the library doesn't have a NOTICE file, then I don't think you need to add one.
There was a problem hiding this comment.
The build requires this file, at least an empty one :-) Can remove the content.
d39adc5 to
a592b9a
Compare
|
Pinging @elastic/es-search (:Search/EQL) |
There was a problem hiding this comment.
Simply add the license from the jar - no need to modify it to add copyright or something else.
There was a problem hiding this comment.
jar has only this blob in pom.xml
<licenses> <license> <name>The Apache Software License, Version 2.0</name> <url>http://www.apache.org/licenses/LICENSE-2.0.txt</url> <distribution>repo</distribution> </license> </licenses>
should I just copy the http://www.apache.org/licenses/LICENSE-2.0.txt content instead there?
There was a problem hiding this comment.
Updated the jtoml-LICENSE file with the license content. Removed the NOTICE file content, but the file needs to be present to pass all the thridparty deps validations here.
There was a problem hiding this comment.
If the library doesn't have a NOTICE file, then I don't think you need to add one.
There was a problem hiding this comment.
The client in the ESRestTestCase base class is created on @before, so this is done in order to get the initialized client but still synchronize the setup and do it once in case the tests are run in parallel.
There was a problem hiding this comment.
You could use the approach used in SQL:
And wipe the data in a @AfterClass. Note that you could do the loading inside @BeforeClass as well if there are no modifications to the index at all.
a592b9a to
c8a4cc0
Compare
|
Rebased against the latest master to resolve the conflicts and force pushed. |
costin
left a comment
There was a problem hiding this comment.
LGTM w/o the synchronized blocks.
Move EqlActionIT to EQL QA project.
Use HL client for EQL verification harness.
Improve the speed of tests, setting the data once and reusing for each parameterized test.
Improve naming for the tests, using "description" or "note" and falling back to "query".
Related to #53598