Fix sorting agg buckets by doc_count#53617
Merged
nik9000 merged 2 commits intoelastic:masterfrom Mar 16, 2020
Merged
Conversation
I broke sorting aggregations by `doc_count` in elastic#51271 by mixing up true and false. This flips that comparison and adds a few tests to double check that we don't so this again.
Collaborator
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
Member
Author
|
I'm using the |
7 tasks
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Mar 16, 2020
I broke sorting aggregations by `doc_count` in elastic#51271 by mixing up true and false. This flips that comparison and adds a few tests to double check that we don't so this again.
nik9000
added a commit
that referenced
this pull request
Mar 16, 2020
PR #53617 has yet to be backported so we should skip its integration test on nodes earlier than 8.0.0
nik9000
added a commit
that referenced
this pull request
Mar 16, 2020
Member
Author
|
Merged and backported, thanks @not-napoleon ! |
|
@nik9000 did the backport go through? |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I broke sorting aggregations by
doc_countin #51271 by mixing up trueand false. This flips that comparison and adds a few tests to double
check that we don't so this again.