[Transform] enhance the output of preview to return full destination index details#53572
Merged
hendrikmuhs merged 2 commits intoelastic:masterfrom Mar 17, 2020
Merged
Conversation
Collaborator
|
Pinging @elastic/ml-core (:ml/Transform) |
5dd8013 to
b466fb0
Compare
benwtrent
approved these changes
Mar 16, 2020
Member
benwtrent
left a comment
There was a problem hiding this comment.
love this change.
One comment about a logging level, but looks good.
Tricky thing with HLRC, all versions need to be forward-compatible with minor versions in the same major.
This change should be OK as the HLRC continues to work as a whole.
...in/transform/src/main/java/org/elasticsearch/xpack/transform/persistence/TransformIndex.java
Outdated
Show resolved
Hide resolved
hendrikmuhs
pushed a commit
to hendrikmuhs/elasticsearch
that referenced
this pull request
Mar 17, 2020
…tic#53572) changes the output format of preview regarding deduced mappings and enhances it to return all the details about auto-index creation. This allows the user to customize the index creation. Using HLRC you can create a index request from the output of the response.
hendrikmuhs
pushed a commit
that referenced
this pull request
Mar 18, 2020
changes the output format of preview regarding deduced mappings and enhances it to return all the details about auto-index creation. This allows the user to customize the index creation. Using HLRC you can create a index request from the output of the response. backport #53572
|
Just caught up with emails and missed the CC unfortunately: We use mappings in the UI to infer field types for the preview tables. I'll come up with a fix this afternoon! |
3 tasks
walterra
added a commit
to elastic/kibana
that referenced
this pull request
Mar 19, 2020
- Fixes regression caused by elastic/elasticsearch#53572. - Adjusts the TS mappings and code to reflect the newly returned API response. - Re-enables functional tests.
walterra
added a commit
to elastic/kibana
that referenced
this pull request
Mar 20, 2020
- Fixes regression caused by elastic/elasticsearch#53572. - Adjusts the TS mappings and code to reflect the newly returned API response. - Re-enables functional tests.
|
Fixed in Kibana for |
38 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes the output format of preview regarding deduced mappings and enhances it to return all the details about auto-index creation. This allows the user to customize the index creation. Using HLRC you can create a index request from the output of the response. Long term this allows us to add UI support, see elastic/kibana#57059 and/or improve setting defaults.
The output of the preview itself is not affected. The UI does not use/display mappings at the moment (CC @walterra )
Breaking:
>=7.7<-><7.7<7.7<->>=7.7(mappings are parsed as empty)New format:
Please raise concerns about the naming:
generated_dest_index.Old format: