Create new geo module and migrate geo_shape registration#53562
Merged
talevy merged 27 commits intoelastic:masterfrom Apr 7, 2020
Merged
Create new geo module and migrate geo_shape registration#53562talevy merged 27 commits intoelastic:masterfrom
geo module and migrate geo_shape registration#53562talevy merged 27 commits intoelastic:masterfrom
Conversation
This commit introduces a new spatial-extras module that is intended to be contain all the geo-spatial-specific features in server. As a first step, the responsibility of registering the geo_shape field mapper is moved to this module.
Collaborator
|
Pinging @elastic/es-analytics-geo (:Analytics/Geo) |
talevy
commented
Mar 13, 2020
| @Override | ||
| protected Collection<Class<? extends Plugin>> getPlugins() { | ||
| return Collections.singleton(MapperExtrasPlugin.class); | ||
| return List.of(MapperExtrasPlugin.class, TestGeoShapeFieldMapperPlugin.class); |
Contributor
Author
There was a problem hiding this comment.
I think there is room to pull the TestGeoShapeFieldMapperPlugin to the parent test class and inherited by those that need it or need to extend to include more plugins. I could see it stay either way since it is fairly low impact and the dependency is expected to go away
rjernst
reviewed
Mar 13, 2020
Member
rjernst
left a comment
There was a problem hiding this comment.
I have a couple questions/suggestions
.../mapper-extras/src/test/java/org/elasticsearch/index/query/RankFeatureQueryBuilderTests.java
Outdated
Show resolved
Hide resolved
modules/spatial-extras/src/main/java/org/elasticsearch/spatial/SpatialExtrasPlugin.java
Outdated
Show resolved
Hide resolved
Contributor
|
@elasticmachine update branch |
Collaborator
|
merge conflict between base and head |
geo module and migrate geo_shape registration
Contributor
Author
|
thanks for pushing those changes to the branch @nknize, I'll get the CI happy from here on out! |
rjernst
approved these changes
Apr 7, 2020
Member
rjernst
left a comment
There was a problem hiding this comment.
LGTM! It will be nice to have a place where we can actually start migrating geo stuff into a module.
Contributor
Author
|
thanks Ryan! |
talevy
added a commit
that referenced
this pull request
Apr 7, 2020
) (#54924) This commit introduces a new `geo` module that is intended to be contain all the geo-spatial-specific features in server. As a first step, the responsibility of registering the geo_shape field mapper is moved to this module. Co-authored-by: Nicholas Knize <nknize@gmail.com>
talevy
added a commit
to talevy/elasticsearch
that referenced
this pull request
Apr 10, 2020
After elastic#53562, the `geo_shape` field mapper is registered within a module. This opens the door for introducing a new `geo_shape` field mapper into the Spatial Plugin that has doc-values support. This is very much an extension of server's GeoShapeFieldMapper, but with the addition of the doc values implementation.
talevy
added a commit
that referenced
this pull request
Apr 16, 2020
After #53562, the `geo_shape` field mapper is registered within a module. This opens the door for introducing a new `geo_shape` field mapper into the Spatial Plugin that has doc-values support. This is very much an extension of server's GeoShapeFieldMapper, but with the addition of the doc values implementation.
talevy
added a commit
that referenced
this pull request
Apr 22, 2020
…#55500) After #53562, the `geo_shape` field mapper is registered within a module. This opens the door for introducing a new `geo_shape` field mapper into the Spatial Plugin that has doc-values support. This is very much an extension of server's GeoShapeFieldMapper, but with the addition of the doc values implementation.
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a new
geomodule that is intendedto contain all the geo-spatial-specific features in server.
As a first step, the responsibility of registering the geo_shape
field mapper is moved to this module.