Change assertion in TimeSeriesLifecycleActionsIT.testHistoryIsWrittenWithFailure#53306
Merged
probakowski merged 3 commits intoelastic:masterfrom Mar 9, 2020
Merged
Conversation
…WithFailure This change modifies `testHistoryIsWrittenWithFailure` to check if there was retry of failed step (through checking `failed_step_retry_count`) instead of looking for `ERROR` step itself. As ILM oscillates between `ERROR` and retried step it's possible we never hit `ERROR` itself, especially with backoff in `assertBusy`. `failed_step_retry_count` is monotonically increasing so assertion will eventually pass.
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/ILM+SLM) |
probakowski
added a commit
to probakowski/elasticsearch
that referenced
this pull request
Mar 9, 2020
Contributor
Author
|
@elasticmachine update branch |
probakowski
added a commit
that referenced
this pull request
Mar 9, 2020
* Avoid race condition in ILMHistorySotre (#53039) * Avoid race condition in ILMHistorySotre This change modifies ILMHistoryStore to always apply correct settings and mappings, even if template is deleted and not yet recreated. This ensures that ILM history index is correctly managed by ILM and also fixes flaky history tests that were prone to triggenring this race. This commit also refactors and simplifies ILM history tests. Closes #50353 and #52853 * Review comment Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * fixed tests * backport #53306 Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jrodewig
added a commit
that referenced
this pull request
May 8, 2020
Moves `HTTP` content from the [Modules][0] section to the [Configuring Elasticsearch][1] section. Supporting changes: * Replaces `http` with `HTTP` throughout * Replaces `HTTP module` with `HTTP layer` throughout * Increments several headings * Adds explicit anchors to several headings * Removes several unneeded `[float]` attributes Closes #53306 [0]: https://www.elastic.co/guide/en/elasticsearch/reference/master/modules.html [1]: https://www.elastic.co/guide/en/elasticsearch/reference/master/settings.html
jrodewig
added a commit
that referenced
this pull request
Jun 1, 2020
Moves `HTTP` content from the [Modules][0] section to the [Configuring Elasticsearch][1] section. Supporting changes: * Replaces `http` with `HTTP` throughout * Replaces `HTTP module` with `HTTP layer` throughout * Increments several headings * Adds explicit anchors to several headings * Removes several unneeded `[float]` attributes Closes #53306 [0]: https://www.elastic.co/guide/en/elasticsearch/reference/master/modules.html [1]: https://www.elastic.co/guide/en/elasticsearch/reference/master/settings.html
jrodewig
added a commit
that referenced
this pull request
Jun 1, 2020
Moves `HTTP` content from the [Modules][0] section to the [Configuring Elasticsearch][1] section. Supporting changes: * Replaces `http` with `HTTP` throughout * Replaces `HTTP module` with `HTTP layer` throughout * Increments several headings * Adds explicit anchors to several headings * Removes several unneeded `[float]` attributes Closes #53306 [0]: https://www.elastic.co/guide/en/elasticsearch/reference/master/modules.html [1]: https://www.elastic.co/guide/en/elasticsearch/reference/master/settings.html
jrodewig
added a commit
that referenced
this pull request
Jun 1, 2020
Moves `HTTP` content from the [Modules][0] section to the [Configuring Elasticsearch][1] section. Supporting changes: * Replaces `http` with `HTTP` throughout * Replaces `HTTP module` with `HTTP layer` throughout * Increments several headings * Adds explicit anchors to several headings * Removes several unneeded `[float]` attributes Closes #53306 [0]: https://www.elastic.co/guide/en/elasticsearch/reference/master/modules.html [1]: https://www.elastic.co/guide/en/elasticsearch/reference/master/settings.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change modifies
testHistoryIsWrittenWithFailureto check if there was retry of failed step(through checking
failed_step_retry_count) instead of looking forERRORstep itself.As ILM oscillates between
ERRORand retried step it's possible we never hitERRORitself,especially with backoff in
assertBusy.failed_step_retry_countis monotonically increasingso assertion will eventually pass.
Closes #52853