Allow _cat indices & aliases to use indices options#53248
Merged
AthenaEryma merged 18 commits intoelastic:masterfrom Mar 13, 2020
Merged
Allow _cat indices & aliases to use indices options#53248AthenaEryma merged 18 commits intoelastic:masterfrom
AthenaEryma merged 18 commits intoelastic:masterfrom
Conversation
This commit adjusts the _cat/indices and _cat/aliases APIs to allow specifying indices options, so that these APIs can handle hidden indices/aliases in the same way as other APIs.
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/CAT APIs) |
przemekwitek
approved these changes
Mar 9, 2020
przemekwitek
left a comment
There was a problem hiding this comment.
LGTM
Looking forward for this feature being merged.
AthenaEryma
commented
Mar 11, 2020
.../security-basic/src/test/java/org/elasticsearch/xpack/security/CatIndicesWithSecurityIT.java
Outdated
Show resolved
Hide resolved
jaymode
requested changes
Mar 12, 2020
Member
jaymode
left a comment
There was a problem hiding this comment.
Nice work and good job spotting the enum value in rest spec! I left some minor comments
rest-api-spec/src/main/resources/rest-api-spec/api/cat.aliases.json
Outdated
Show resolved
Hide resolved
rest-api-spec/src/main/resources/rest-api-spec/api/indices.get_alias.json
Outdated
Show resolved
Hide resolved
rest-api-spec/src/main/resources/rest-api-spec/test/cat.aliases/40_hidden.yml
Outdated
Show resolved
Hide resolved
rest-api-spec/src/main/resources/rest-api-spec/test/cat.indices/20_hidden.yml
Outdated
Show resolved
Hide resolved
rest-api-spec/src/main/resources/rest-api-spec/test/cat.indices/20_hidden.yml
Outdated
Show resolved
Hide resolved
rest-api-spec/src/main/resources/rest-api-spec/test/cat.indices/20_hidden.yml
Outdated
Show resolved
Hide resolved
.../security-basic/src/test/java/org/elasticsearch/xpack/security/CatIndicesWithSecurityIT.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine update branch |
AthenaEryma
added a commit
to AthenaEryma/elasticsearch
that referenced
this pull request
Mar 13, 2020
This commit adjusts the _cat/indices and _cat/aliases APIs to allow specifying indices options, so that these APIs can handle hidden indices/aliases in the same way as other APIs. Also adds the hidden option to the expand_wildcards parameter in the YAML spec for every API that accepts it.
AthenaEryma
added a commit
that referenced
this pull request
Mar 16, 2020
This commit adjusts the _cat/indices and _cat/aliases APIs to allow specifying indices options, so that these APIs can handle hidden indices/aliases in the same way as other APIs. Also adds the hidden option to the expand_wildcards parameter in the YAML spec for every API that accepts it.
This was referenced Mar 16, 2020
38 tasks
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Apr 16, 2020
Relates: elastic/elasticsearch#52547 Relates: elastic/elasticsearch#53248 This commit adds the ability to mark indices and aliases as hidden.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adjusts the _cat/indices and _cat/aliases APIs to allow
specifying indices options, so that these APIs can handle hidden
indices/aliases in the same way as other APIs.
Also adds the
hiddenoption to theexpand_wildcardsparameterin the YAML spec for every API that accepts it.
Relates #52304