ValuesSource refactoring: Wire up ExtendedStats aggregation#53227
Merged
csoulios merged 7 commits intoelastic:feature/extensible-values-sourcefrom Mar 16, 2020
Merged
Conversation
Collaborator
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
85 tasks
…-up-extended-stats
not-napoleon
approved these changes
Mar 6, 2020
Member
not-napoleon
left a comment
There was a problem hiding this comment.
LGTM. We've seen that CI failure on a few PRs, and I think Tal pulled in the fix from master. If you merge the feature branch, it should go to green.
…-up-extended-stats
Contributor
Author
|
@elasticmachine run elasticsearch-ci/bwc |
Replaced it with ExtendedStatsAggregationBuilder.PARSE
Contributor
Author
|
@elasticmachine run elasticsearch-ci/bwc |
…-up-extended-stats
Contributor
Author
|
@elasticmachine run elasticsearch-ci/bwc |
…-up-extended-stats
not-napoleon
pushed a commit
to not-napoleon/elasticsearch
that referenced
this pull request
Mar 26, 2020
not-napoleon
added a commit
that referenced
this pull request
Mar 31, 2020
* ValuesSource refactor wire up missing agg (#53511) Part of refactoring ValuesSource in #42949 * ValuesSource refactoring: Wire up ExtendedStats aggregation (#53227) * Javadoc for ValuesSource related work (#53427) Co-authored-by: Andy Bristol <andy.bristol@elastic.co> Co-authored-by: Christos Soulios <1561376+csoulios@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire up ExtendedStats aggregation for #42949