Mute GoogleCloudStorageBlobStoreRepositoryTests on jdk8#53119
Merged
tlrx merged 1 commit intoelastic:7.xfrom Mar 5, 2020
Merged
Mute GoogleCloudStorageBlobStoreRepositoryTests on jdk8#53119tlrx merged 1 commit intoelastic:7.xfrom
tlrx merged 1 commit intoelastic:7.xfrom
Conversation
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
Contributor
|
I think we only need to do this for 7.x, as master is not running against JDK 8 anymore. |
14990a8 to
6b62fa6
Compare
Member
Author
Pffff of course. I changed the base branch to target 7.x. |
original-brownbear
approved these changes
Mar 5, 2020
Contributor
original-brownbear
left a comment
There was a problem hiding this comment.
LGTM, thanks for taking care of this Tanguy!
Member
Author
|
Thanks Armin! |
tlrx
added a commit
that referenced
this pull request
Mar 5, 2020
Tests in GoogleCloudStorageBlobStoreRepositoryTests are known to be flaky on JDK 8 (#51446, #52430 ) and we suspect a JDK bug (https://bugs.openjdk.java.net/browse/JDK-8180754) that triggers some assertion on the server side logic that emulates the Google Cloud Storage service. Sadly we were not able to reproduce the failures, even when using the same OS (Debian 9, Ubuntu 16.04) and JDK (Oracle Corporation 1.8.0_241 [Java HotSpot(TM) 64-Bit Server VM 25.241-b07]) of almost all the test failures on CI. While we spent some time fixing code (#51933, #52431) to circumvent the JDK bug they are still flaky on JDK-8. This commit mute these tests for JDK-8 only. Close ##52906
original-brownbear
added a commit
that referenced
this pull request
Apr 17, 2020
original-brownbear
added a commit
that referenced
this pull request
Apr 17, 2020
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Jun 30, 2021
See elastic#53119 for more context. Also relates elastic#74739.
tlrx
added a commit
that referenced
this pull request
Jun 30, 2021
benwtrent
pushed a commit
to benwtrent/elasticsearch
that referenced
this pull request
Jun 30, 2021
See elastic#53119 for more context about why those tests are muted on JDK8. They start failing more often recently now elastic#74313 and elastic#74620 have been merged, as reported in elastic#74739.
benwtrent
added a commit
that referenced
this pull request
Jun 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests in GoogleCloudStorageBlobStoreRepositoryTests are known to be flaky on JDK 8 (#51446, #52430 ) and we suspect a JDK bug (https://bugs.openjdk.java.net/browse/JDK-8180754) that triggers some assertion on the server side logic that emulates the Google Cloud Storage service.
Sadly we were not able to reproduce the failures, even when using the same OS (Debian 9, Ubuntu 16.04) and JDK (Oracle Corporation 1.8.0_241 [Java HotSpot(TM) 64-Bit Server VM 25.241-b07]) of almost all the test failures on CI.
Close ##52906
While Armin spent some time fixing code (#51933, #52431) to circumvent the JDK bug they are still flaky on JDK-8. This pull request is a proposal to mute these tests for JDK-8 only.