Require manifest file for upgrades to v8#52412
Closed
DaveCTurner wants to merge 1 commit intoelastic:masterfrom
Closed
Require manifest file for upgrades to v8#52412DaveCTurner wants to merge 1 commit intoelastic:masterfrom
DaveCTurner wants to merge 1 commit intoelastic:masterfrom
Conversation
7.x nodes permit the on-disk cluster metadata to omit the manifest file in order to support upgrades from 6.x. We are similarly lenient in `master`, i.e. 8.x, but there is no need to be since we must be upgrading from a 7.x node which ensures that the manifest file is written. This commit removes the lenient loading of a manifest-free cluster metadata from `master`. Relates elastic#38556
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Cluster Coordination) |
ywelsch
suggested changes
Feb 17, 2020
Contributor
ywelsch
left a comment
There was a problem hiding this comment.
I think we should leave the logic untouched. There's no good reason to make this change in 8, with the default storage mechanism having changed anyway. Instead I would just remove the assertion.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Feb 21, 2020
7.x nodes permit the on-disk cluster metadata to omit the manifest file in order to support upgrades from 6.x. We are similarly lenient in `master`, i.e. 8.x, but there is no need to be since we must be upgrading from a 7.x node which ensures that the manifest file is written. We prefer to keep this lenience (see elastic#52412) so this commit removes the commented-out indications that it should be removed. The new metadata format introduced in elastic#50907 means that this whole subsystem will be removed in v9 anyway. Relates elastic#38556
Member
Author
|
Very well, closing in favour of #52646 |
DaveCTurner
added a commit
that referenced
this pull request
Feb 21, 2020
7.x nodes permit the on-disk cluster metadata to omit the manifest file in order to support upgrades from 6.x. We are similarly lenient in `master`, i.e. 8.x, but there is no need to be since we must be upgrading from a 7.x node which ensures that the manifest file is written. We prefer to keep this lenience (see #52412) so this commit removes the commented-out indications that it should be removed. The new metadata format introduced in #50907 means that this whole subsystem will be removed in v9 anyway. Relates #38556
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
7.x nodes permit the on-disk cluster metadata to omit the manifest file in
order to support upgrades from 6.x. We are similarly lenient in
master, i.e.8.x, but there is no need to be since we must be upgrading from a 7.x node
which ensures that the manifest file is written.
This commit removes the lenient loading of a manifest-free cluster metadata
from
master.Relates #38556