Skip to content

Fix testPrepareIndexForPeerRecovery#52245

Merged
dnhatn merged 1 commit intoelastic:masterfrom
dnhatn:fix-prepare-index
Feb 12, 2020
Merged

Fix testPrepareIndexForPeerRecovery#52245
dnhatn merged 1 commit intoelastic:masterfrom
dnhatn:fix-prepare-index

Conversation

@dnhatn
Copy link
Copy Markdown
Member

@dnhatn dnhatn commented Feb 11, 2020

Since #51905, we skip translog recovery if the local checkpoint of the safe commit equals to the global checkpoint. This change adjusts the test not to create a new snapshot in that case.

Closes #52221
Relates #51905

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests :Distributed/Recovery Anything around constructing a new shard, either from a local or a remote source. v8.0.0 v7.7.0 labels Feb 11, 2020
@dnhatn dnhatn requested a review from ywelsch February 11, 2020 23:23
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-distributed (:Distributed/Recovery)

Copy link
Copy Markdown
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn dnhatn merged commit 0c7ae02 into elastic:master Feb 12, 2020
@dnhatn dnhatn deleted the fix-prepare-index branch February 12, 2020 16:08
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Feb 26, 2020
Since elastic#51905, we skip translog recovery if the local checkpoint of the
safe commit equals to the global checkpoint. This change adjusts the
test not to create a new snapshot in that case.

Closes elastic#52221
Relates elastic#51905
dnhatn added a commit that referenced this pull request Feb 26, 2020
Since #51905, we skip translog recovery if the local checkpoint of the
safe commit equals to the global checkpoint. This change adjusts the
test not to create a new snapshot in that case.

Closes #52221
Relates #51905
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Recovery Anything around constructing a new shard, either from a local or a remote source. >test Issues or PRs that are addressing/adding tests v7.7.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] PeerRecoveryTargetServiceTests testPrepareIndexForPeerRecovery failure

4 participants