Skip to content

Add autoscaling feature flag in release REST tests#52096

Merged
jasontedor merged 1 commit intoelastic:masterfrom
jasontedor:register-autoscaling-feature-flag-release-rest-tests
Feb 9, 2020
Merged

Add autoscaling feature flag in release REST tests#52096
jasontedor merged 1 commit intoelastic:masterfrom
jasontedor:register-autoscaling-feature-flag-release-rest-tests

Conversation

@jasontedor
Copy link
Copy Markdown
Member

The REST tests for autoscaling either need to be skipped in a non-snapshot build, or alternatively, the feature flag registered so that autoscaling can be enabled. We prefer the latter approach, as it allows us to also test autoscaling in non-snapshot builds incrementally, instead of at the end of development as autoscaling prepares for release. This commit registers the autoscaling feature flag in REST tests for non-snapshot builds.

Relates #52088

The REST tests for autoscaling either need to be skipped in a
non-snapshot build, or alternatively, the feature flag registered so
that autoscaling can be enabled. We prefer the latter approach, as it
allows us to also test autoscaling in non-snapshot builds incrementally,
instead of at the end of development as autoscaling prepares for
release. This commit registers the autoscaling feature flag in REST
tests for non-snapshot builds.
@jasontedor jasontedor added the :Distributed/Autoscaling Automatically adding or removing nodes in a cluster label Feb 8, 2020
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-distributed (:Distributed/Autoscaling)

@jasontedor
Copy link
Copy Markdown
Member Author

Here is a build scan showing the issue.

@jasontedor jasontedor mentioned this pull request Feb 8, 2020
9 tasks
Copy link
Copy Markdown
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasontedor jasontedor merged commit da5b35b into elastic:master Feb 9, 2020
jasontedor added a commit that referenced this pull request Feb 9, 2020
The REST tests for autoscaling either need to be skipped in a
non-snapshot build, or alternatively, the feature flag registered so
that autoscaling can be enabled. We prefer the latter approach, as it
allows us to also test autoscaling in non-snapshot builds incrementally,
instead of at the end of development as autoscaling prepares for
release. This commit registers the autoscaling feature flag in REST
tests for non-snapshot builds.
@jasontedor jasontedor deleted the register-autoscaling-feature-flag-release-rest-tests branch February 9, 2020 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Autoscaling Automatically adding or removing nodes in a cluster >non-issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants