Skip to content

SQL: [Tests] Add more tests for aggs and literals#52086

Merged
matriv merged 1 commit intoelastic:masterfrom
matriv:add-tests-groupby-literals
Feb 9, 2020
Merged

SQL: [Tests] Add more tests for aggs and literals#52086
matriv merged 1 commit intoelastic:masterfrom
matriv:add-tests-groupby-literals

Conversation

@matriv
Copy link
Copy Markdown
Contributor

@matriv matriv commented Feb 7, 2020

Add some more tests where more than one literal is selected.
Test with both unaliased and aliased literals.

Follows: #42121

Add some more tests where more than one literal is selected,
unaliased and aliased.

Follows: elastic#42121
@matriv matriv added >test Issues or PRs that are addressing/adding tests :Analytics/SQL SQL querying v8.0.0 v7.7.0 v7.6.1 labels Feb 7, 2020
@matriv matriv requested a review from astefan February 7, 2020 22:54
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-search (:Search/SQL)

Copy link
Copy Markdown
Contributor

@astefan astefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matriv matriv merged commit 405271d into elastic:master Feb 9, 2020
@matriv matriv deleted the add-tests-groupby-literals branch February 9, 2020 17:00
matriv added a commit that referenced this pull request Feb 9, 2020
Add some more tests where more than one literal is selected,
unaliased and aliased.

Follows: #42121
(cherry picked from commit 405271d)
matriv added a commit that referenced this pull request Feb 9, 2020
Add some more tests where more than one literal is selected,
unaliased and aliased.

Follows: #42121
(cherry picked from commit 405271d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/SQL SQL querying >test Issues or PRs that are addressing/adding tests v7.6.1 v7.7.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants