Reenable testWhenUserLimitedByOnlyAliasOfIndexCanWriteToIndexWhichWasRolledoverByILMPolicy#51768
Merged
andreidan merged 4 commits intoelastic:masterfrom Jan 31, 2020
Merged
Conversation
…RolledoverByILMPolicy This also adds `profile: true` to the search request and executes an additional explain query request when the test fails.
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/ILM+SLM) |
…WhichWasRolledoverByILMPolicy" This reverts commit 7f10e3b.
…RolledoverByILMPolicy
We suspect the flakiness could’ve come from the fact that the rollover
step used to create the new index and roll the write alias to the new
index in separate cluster state updates. So the assertion that the
rolled index exists could’ve passed in the test but, before the
alias was rolled over to the new index, the subsequent write we execute
in the test (namely
`indexDocs("test_user", "x-pack-test-password", "foo_alias", 1)`)
would’ve sent the new document to the source index (ie. foo-logs-000001)
This would see the source index containing 3 documents and the rolled
index (foo-logs-000002) 0 documents.
However, we fixed this and the rollover step executes the “create index
and roll alias” in one single cluster update, so this situation should
not occur anymore.
dakrone
approved these changes
Jan 31, 2020
Member
dakrone
left a comment
There was a problem hiding this comment.
LGTM, can you change the PR description to describe why this should be fixed (instead of talking about the profiling)?
Contributor
Author
|
@dakrone yes, dropped all that, thanks! |
Contributor
Author
|
@elasticmachine update branch |
andreidan
added a commit
to andreidan/elasticsearch
that referenced
this pull request
Feb 3, 2020
…RolledoverByILMPolicy (elastic#51768) We suspect the flakiness could’ve come from the fact that the rollover step used to create the new index and roll the write alias to the new index in separate cluster state updates. So the assertion that the rolled index exists could’ve passed in the test but, before the alias was rolled over to the new index, the subsequent write we execute in the test (namely `indexDocs("test_user", "x-pack-test-password", "foo_alias", 1)`) would’ve sent the new document to the source index (ie. foo-logs-000001) This would see the source index containing 3 documents and the rolled index (foo-logs-000002) 0 documents. However, we fixed this and the rollover step executes the “create index and roll alias” in one single cluster update, so this situation should not occur anymore. (cherry picked from commit 834261c) Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
andreidan
added a commit
that referenced
this pull request
Feb 3, 2020
…RolledoverByILMPolicy (#51768) (#51801) We suspect the flakiness could’ve come from the fact that the rollover step used to create the new index and roll the write alias to the new index in separate cluster state updates. So the assertion that the rolled index exists could’ve passed in the test but, before the alias was rolled over to the new index, the subsequent write we execute in the test (namely `indexDocs("test_user", "x-pack-test-password", "foo_alias", 1)`) would’ve sent the new document to the source index (ie. foo-logs-000001) This would see the source index containing 3 documents and the rolled index (foo-logs-000002) 0 documents. However, we fixed this and the rollover step executes the “create index and roll alias” in one single cluster update, so this situation should not occur anymore. (cherry picked from commit 834261c) Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We suspect the flakiness could’ve come from the fact that the rollover
step used to create the new index and roll the write alias to the new
index in separate cluster state updates. So the assertion that the
rolled index exists could’ve passed in the test but, before the
alias was rolled over to the new index, the subsequent write we execute
in the test (namely
indexDocs("test_user", "x-pack-test-password", "foo_alias", 1))would’ve sent the new document to the source index (ie.
foo-logs-000001)This would see the source index containing 3 documents and the rolled
index (
foo-logs-000002) 0 documents.However, we fixed this and the rollover step executes the “create index
and roll alias” in one single cluster update, so this situation should
not occur anymore.
Resolves #41440