Skip to content

Fix testThatNonExistingTemplatesAreAddedImmediately#51668

Merged
andreidan merged 1 commit intoelastic:masterfrom
andreidan:fix-testThatNonExistingTemplatesAreAddedImm
Jan 31, 2020
Merged

Fix testThatNonExistingTemplatesAreAddedImmediately#51668
andreidan merged 1 commit intoelastic:masterfrom
andreidan:fix-testThatNonExistingTemplatesAreAddedImm

Conversation

@andreidan
Copy link
Copy Markdown
Contributor

This addresses another race condition that could yield this test flaky.

Resolves #43950

This addresses another race condition that could yield this test flaky.
@andreidan andreidan added >test Issues or PRs that are addressing/adding tests :Data Management/ILM+SLM DO NOT USE. Use ":StorageEngine/ILM" or ":Distributed Coordination/SLM" instead. v8.0.0 labels Jan 30, 2020
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-features (:Core/Features/ILM+SLM)

@andreidan andreidan requested a review from dakrone January 30, 2020 12:39
Copy link
Copy Markdown
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again!

@dakrone
Copy link
Copy Markdown
Member

dakrone commented Jan 30, 2020

Should this go to the 7.x branch also? I think so if the test exists there?

@andreidan andreidan merged commit d20d90a into elastic:master Jan 31, 2020
andreidan added a commit to andreidan/elasticsearch that referenced this pull request Jan 31, 2020
This addresses another race condition that could yield this test flaky.

(cherry picked from commit d20d90a)
Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
andreidan added a commit that referenced this pull request Jan 31, 2020
This addresses another race condition that could yield this test flaky.

(cherry picked from commit d20d90a)
Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Data Management/ILM+SLM DO NOT USE. Use ":StorageEngine/ILM" or ":Distributed Coordination/SLM" instead. >test Issues or PRs that are addressing/adding tests v7.7.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SnapshotLifecycleTemplateRegistryTests.testThatNonExistingTemplatesAreAddedImmediately fails on CI non-reproducibly

4 participants