Skip to content

[DOCS] Reformat trim token filter docs#51649

Merged
jrodewig merged 1 commit intoelastic:masterfrom
jrodewig:docs__reformat-trim-tokenfilter
Mar 2, 2020
Merged

[DOCS] Reformat trim token filter docs#51649
jrodewig merged 1 commit intoelastic:masterfrom
jrodewig:docs__reformat-trim-tokenfilter

Conversation

@jrodewig
Copy link
Copy Markdown
Contributor

Makes the following changes to the trim token filter docs:

  • Updates description
  • Adds a link to the related Lucene filter
  • Adds tip about removing whitespace using tokenizers
  • Adds detailed analyze snippets
  • Adds custom analyzer snippet

Makes the following changes to the `trim` token filter docs:

* Updates description
* Adds a link to the related Lucene filter
* Adds tip about removing whitespace using tokenizers
* Adds detailed analyze snippets
* Adds custom analyzer snippet
@jrodewig jrodewig added >docs General docs changes :Search Relevance/Analysis How text is split into tokens labels Jan 29, 2020
@jrodewig jrodewig requested a review from romseygeek January 29, 2020 21:24
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-search (:Search/Analysis)

Copy link
Copy Markdown
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - apologies for the late review, I think I missed this at the time

@jrodewig
Copy link
Copy Markdown
Contributor Author

jrodewig commented Mar 2, 2020

No worries at all. Thanks @romseygeek.

@jrodewig jrodewig merged commit 996ec0d into elastic:master Mar 2, 2020
@jrodewig jrodewig deleted the docs__reformat-trim-tokenfilter branch March 2, 2020 12:47
jrodewig added a commit that referenced this pull request Mar 2, 2020
Makes the following changes to the `trim` token filter docs:

* Updates description
* Adds a link to the related Lucene filter
* Adds tip about removing whitespace using tokenizers
* Adds detailed analyze snippets
* Adds custom analyzer snippet
jrodewig added a commit that referenced this pull request Mar 2, 2020
Makes the following changes to the `trim` token filter docs:

* Updates description
* Adds a link to the related Lucene filter
* Adds tip about removing whitespace using tokenizers
* Adds detailed analyze snippets
* Adds custom analyzer snippet
@jrodewig
Copy link
Copy Markdown
Contributor Author

jrodewig commented Mar 2, 2020

Backport commits

master 996ec0d
7.x d336faa
7.6 0ae897d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>docs General docs changes :Search Relevance/Analysis How text is split into tokens v7.6.2 v7.7.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants