Optimize GCS Repo Uploads#51596
Merged
original-brownbear merged 2 commits intoelastic:masterfrom Jan 29, 2020
original-brownbear:optimize-gcs-small-uploads
Merged
Optimize GCS Repo Uploads#51596original-brownbear merged 2 commits intoelastic:masterfrom original-brownbear:optimize-gcs-small-uploads
original-brownbear merged 2 commits intoelastic:masterfrom
original-brownbear:optimize-gcs-small-uploads
Conversation
For small uploads (that can still be up to 5MB!) we needlessly reading the `InputStream` into a BAOS which entailed allocating the `byte[]` for the stream contents twice (because to `toByteArray` on the BAOS copies). Relates #51593
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
Contributor
Author
|
Np + thanks Tanguy! |
original-brownbear
added a commit
that referenced
this pull request
Jan 29, 2020
For small uploads (that can still be up to 5MB!) we needlessly reading the `InputStream` into a BAOS which entailed allocating the `byte[]` for the stream contents twice (because to `toByteArray` on the BAOS copies). Also, for resumeable uploads we were needlessly wrapping the output channel and running each individual write in its own privileged context when we could just wrap the whole upload in a single privileged context. Relates #51593
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For small uploads (that can still be up to 5MB!) we needlessly
reading the
InputStreaminto a BAOS which entailed allocatingthe
byte[]for the stream contents twice (because totoByteArrayon the BAOS copies).Also, for resumeable uploads we were needlessly wrapping the output channel and running each individual write in its own privileged context when we could just wrap the whole upload in a single privileged context.
Relates #51593