Remove translog retention policy#51417
Merged
dnhatn merged 4 commits intoelastic:masterfrom Jan 24, 2020
Merged
Conversation
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Engine) |
ywelsch
reviewed
Jan 24, 2020
Contributor
ywelsch
left a comment
There was a problem hiding this comment.
Great PR stats. I've left some minor comments.
server/src/main/java/org/elasticsearch/index/translog/TranslogDeletionPolicy.java
Show resolved
Hide resolved
Member
Author
|
run elasticsearch-ci/2 |
Member
Author
|
Thanks Yannick. |
dnhatn
added a commit
that referenced
this pull request
Jan 31, 2020
Before #51417, trimUnreferencedReaders in this test was a noop as the default translog retention policy was 512MB and 12h, which was long enough to keep all translog files. Two problems in this test: - We do not consider any failure while trimming unreferenced readers as a tragedy. - We should clear the synced list before calling trimUnreferencedReaders. Relates #51505 Closes #51694
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We no longer need to retain the extra translog for peer recovery as we have switched using Lucene index exclusively in 8.0. This change removes the translog retention policy.
I think we can also remove the async trim translog task. I will do it in a separate PR.
Relates #50775