Skip to content

Use separate policies for tests in SnapshotLifecycleRestIT#51075

Merged
dakrone merged 1 commit intoelastic:masterfrom
dakrone:ilm-fix-SnapshotLifecycleRestIT-stats
Jan 17, 2020
Merged

Use separate policies for tests in SnapshotLifecycleRestIT#51075
dakrone merged 1 commit intoelastic:masterfrom
dakrone:ilm-fix-SnapshotLifecycleRestIT-stats

Conversation

@dakrone
Copy link
Copy Markdown
Member

@dakrone dakrone commented Jan 15, 2020

These policies store statistics, but since stats updating is asynchronous, it's
possible for the update from one test to bleed into a separate one. This change
switches the tests to use separate policy ids so that their stats are tracked
independently. It also relaxes the checking constraint in one of the tests.

Hopefully this:
Resolves #48531
Resolves #48017

These policies store statistics, but since stats updating is asynchronous, it's
possible for the update from one test to bleed into a separate one. This change
switches the tests to use separate policy ids so that their stats are tracked
independently. It also relaxes the checking constraint in one of the tests.

Hopefully this:
Resolves elastic#48531
Resolves elastic#48017
@dakrone dakrone added >test Issues or PRs that are addressing/adding tests :Data Management/ILM+SLM DO NOT USE. Use ":StorageEngine/ILM" or ":Distributed Coordination/SLM" instead. v8.0.0 v7.7.0 labels Jan 15, 2020
@dakrone dakrone requested a review from andreidan January 15, 2020 22:26
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-features (:Core/Features/ILM+SLM)

Copy link
Copy Markdown
Contributor

@andreidan andreidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Hopefully this does it. Thanks @dakrone

LGTM

@dakrone dakrone merged commit 16994c8 into elastic:master Jan 17, 2020
@dakrone dakrone deleted the ilm-fix-SnapshotLifecycleRestIT-stats branch January 17, 2020 19:16
dakrone added a commit to dakrone/elasticsearch that referenced this pull request Jan 17, 2020
…1075)

These policies store statistics, but since stats updating is asynchronous, it's
possible for the update from one test to bleed into a separate one. This change
switches the tests to use separate policy ids so that their stats are tracked
independently. It also relaxes the checking constraint in one of the tests.

Hopefully this:
Resolves elastic#48531
Resolves elastic#48017
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
…1075)

These policies store statistics, but since stats updating is asynchronous, it's
possible for the update from one test to bleed into a separate one. This change
switches the tests to use separate policy ids so that their stats are tracked
independently. It also relaxes the checking constraint in one of the tests.

Hopefully this:
Resolves elastic#48531
Resolves elastic#48017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Data Management/ILM+SLM DO NOT USE. Use ":StorageEngine/ILM" or ":Distributed Coordination/SLM" instead. >test Issues or PRs that are addressing/adding tests v7.7.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SnapshotLifecycleRestIT#testPolicyManualExecution failed SnapshotLifecycleRestIT » testBasicTimeBasedRetenion failure

4 participants