[Transform] Improve force stop robustness in case of an error#51072
Merged
hendrikmuhs merged 3 commits intoelastic:masterfrom Jan 17, 2020
Merged
[Transform] Improve force stop robustness in case of an error#51072hendrikmuhs merged 3 commits intoelastic:masterfrom
hendrikmuhs merged 3 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/ml-core (:ml/Transform) |
Contributor
dimitris-athanasiou
left a comment
There was a problem hiding this comment.
Looks good. A few minor things to go through.
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/transform/TransformMessages.java
Outdated
Show resolved
Hide resolved
...orm/src/main/java/org/elasticsearch/xpack/transform/action/TransportStopTransformAction.java
Outdated
Show resolved
Hide resolved
...orm/src/main/java/org/elasticsearch/xpack/transform/action/TransportStopTransformAction.java
Outdated
Show resolved
Hide resolved
dimitris-athanasiou
approved these changes
Jan 16, 2020
Contributor
dimitris-athanasiou
left a comment
There was a problem hiding this comment.
LGTM Cool, the only thing I'd add would be a test for when the tranform id in the _stop call is a wildcard pattern (e.g. "foo-*"). But i'll leave it on you whether to add it in this PR or another.
hendrikmuhs
pushed a commit
that referenced
this pull request
Jan 17, 2020
If a transform config got lost (e.g. because the internal index disappeared) tasks could not be stopped using transform API. This change makes it possible to stop transforms without a config, meaning to remove the background task. In order to do so force must be set to true.
hendrikmuhs
pushed a commit
that referenced
this pull request
Jan 17, 2020
If a transform config got lost (e.g. because the internal index disappeared) tasks could not be stopped using transform API. This change makes it possible to stop transforms without a config, meaning to remove the background task. In order to do so force must be set to true.
This was referenced Jan 17, 2020
hendrikmuhs
pushed a commit
that referenced
this pull request
Jan 20, 2020
hendrikmuhs
pushed a commit
that referenced
this pull request
Jan 20, 2020
hendrikmuhs
pushed a commit
that referenced
this pull request
Jan 20, 2020
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
…c#51072) If a transform config got lost (e.g. because the internal index disappeared) tasks could not be stopped using transform API. This change makes it possible to stop transforms without a config, meaning to remove the background task. In order to do so force must be set to true.
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
check custom meta data to avoid NPE, fixes a problem introduced in elastic#51072 fixes elastic#51153
This was referenced Feb 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a transform config got lost (e.g. because the internal index disappeared) tasks could not be stopped using transform API. This change makes it possible to stop transforms without a config, meaning to remove the background task. In order to do so force must be set to true.