Allow installing multiple plugins as a transaction#50924
Merged
jasontedor merged 3 commits intoelastic:masterfrom Jan 14, 2020
Merged
Allow installing multiple plugins as a transaction#50924jasontedor merged 3 commits intoelastic:masterfrom
jasontedor merged 3 commits intoelastic:masterfrom
Conversation
This commit allows the plugin installer to install multiple plugins in a single invocation. The installation will be treated as a transaction, so that all of the plugins are install successfully, or none of the plugins are installed.
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Plugins) |
rjernst
reviewed
Jan 14, 2020
Member
rjernst
left a comment
There was a problem hiding this comment.
Looks good, minor request on testing
distribution/tools/plugin-cli/src/main/java/org/elasticsearch/plugins/InstallPluginCommand.java
Outdated
Show resolved
Hide resolved
distribution/tools/plugin-cli/src/main/java/org/elasticsearch/plugins/InstallPluginCommand.java
Show resolved
Hide resolved
...tion/tools/plugin-cli/src/test/java/org/elasticsearch/plugins/InstallPluginCommandTests.java
Show resolved
Hide resolved
Member
Author
|
Thanks @rjernst. I have responded to your feedback. |
Member
Author
|
@elasticmachine update branch |
rjernst
approved these changes
Jan 14, 2020
Member
rjernst
left a comment
There was a problem hiding this comment.
LGTM. I still think we should output something as each plugin is installed so it is not a black box to the end, but that can always be changed later.
Member
Author
|
@elasticmachine run elasticsearch-ci/2 |
1 similar comment
Member
Author
|
@elasticmachine run elasticsearch-ci/2 |
jasontedor
added a commit
that referenced
this pull request
Jan 14, 2020
This commit allows the plugin installer to install multiple plugins in a single invocation. The installation will be treated as a transaction, so that all of the plugins are install successfully, or none of the plugins are installed.
Member
Author
See #51001 and let me know what you think? |
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
This commit allows the plugin installer to install multiple plugins in a single invocation. The installation will be treated as a transaction, so that all of the plugins are install successfully, or none of the plugins are installed.
This was referenced Feb 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit allows the plugin installer to install multiple plugins in a single invocation. The installation will be treated as a transaction, so that all of the plugins are install successfully, or none of the plugins are installed.
Relates #50443