Merged
Conversation
14 tasks
Contributor
Author
|
@elasticmachine run elasticsearch-ci/2 |
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Cluster Coordination) |
d2000bb to
119a4a9
Compare
DaveCTurner
approved these changes
Jan 14, 2020
Member
DaveCTurner
left a comment
There was a problem hiding this comment.
LGTM, some comments/questions on UX & docs but nothing major.
server/src/main/java/org/elasticsearch/cluster/coordination/RemoveCustomsCommand.java
Show resolved
Hide resolved
Co-Authored-By: David Turner <david.turner@elastic.co>
ywelsch
added a commit
that referenced
this pull request
Jan 14, 2020
Bad interaction with other recently merged PR.
ywelsch
added a commit
that referenced
this pull request
Jan 14, 2020
Adds a command-line tool to remove broken custom metadata from the cluster state. Relates to #48701
|
Hi, only a minor remark related to the title of this PR as well as in #50694 both of which appear in blog notes (https://www.elastic.co/blog/this-week-in-elasticsearch-and-apache-lucene-2020-01-17), I find them ambiguous and would find a naming like below better:
Anyway, thanks for that! |
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
Adds a command-line tool to remove broken custom metadata from the cluster state. Relates to elastic#48701
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
Bad interaction with other recently merged PR.
This was referenced Feb 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a command-line tool to remove broken custom metadata from the cluster state.
Relates to #48701