Fix Snapshot Shard Status Request Deduplication#50788
Merged
original-brownbear merged 3 commits intoelastic:masterfrom Jan 10, 2020
original-brownbear:shard-status-request-dedup
Merged
Fix Snapshot Shard Status Request Deduplication#50788original-brownbear merged 3 commits intoelastic:masterfrom original-brownbear:shard-status-request-dedup
original-brownbear merged 3 commits intoelastic:masterfrom
original-brownbear:shard-status-request-dedup
Conversation
The request deduplication didn't actually work for these requests since they had no `equals` and `hashCode` so the deduplicator wouldn't actually recognize equal requests.
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
Contributor
Author
|
Jenkins run elasticsearch-ci/2 (known ILM test failure) |
dnhatn
approved these changes
Jan 9, 2020
server/src/main/java/org/elasticsearch/snapshots/SnapshotShardsService.java
Show resolved
Hide resolved
dnhatn
approved these changes
Jan 9, 2020
Member
dnhatn
left a comment
There was a problem hiding this comment.
LGTM. Thanks Armin for an extra iteration :).
Contributor
Author
|
Jenkins run elasticsearch-ci/2 (failure is known ILM test failure) |
Contributor
Author
|
Jenkins run elasticsearch-ci/2 (failure is known ILM test failure again ...) |
Contributor
Author
|
Thanks Nhat! |
original-brownbear
added a commit
that referenced
this pull request
Jan 10, 2020
This was referenced Jan 21, 2020
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
* Fix Snapshot Shard Status Request Deduplication The request deduplication didn't actually work for these requests since they had no `equals` and `hashCode` so the deduplicator wouldn't actually recognize equal requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The request deduplication didn't actually work for these requests
since they had no
equalsandhashCodeso the deduplicator wouldn'tactually recognize equal requests.