Skip to content

[DOCS] Reformat unique token filter docs#50748

Merged
jrodewig merged 1 commit intoelastic:masterfrom
jrodewig:reformat.unique-token-filter
Jan 28, 2020
Merged

[DOCS] Reformat unique token filter docs#50748
jrodewig merged 1 commit intoelastic:masterfrom
jrodewig:reformat.unique-token-filter

Conversation

@jrodewig
Copy link
Copy Markdown
Contributor

@jrodewig jrodewig commented Jan 8, 2020

Changes

  • Updates the description
  • Adds note re: remove_duplicates filter
  • Adds analyze, custom analyzer, and custom filter snippets
  • Adds parameter documentation

* Updates the description
* Adds analyze, custom analyzer, and custom filter snippets
* Adds parameter documentation
@jrodewig jrodewig added >docs General docs changes :Search Relevance/Analysis How text is split into tokens labels Jan 8, 2020
@jrodewig jrodewig requested a review from romseygeek January 8, 2020 15:49
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-search (:Search/Analysis)

Comment on lines +13 to +17
[NOTE]
====
When `only_on_same_position` is `true`, the `unique` filter works the same as
<<analysis-remove-duplicates-tokenfilter,`remove_duplicates`>> filter.
====
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@romseygeek Do you know if there's any reason for users to prefer one of these filters over another? If so, I can note that here.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, missed this! unique has the ability to work over an entire token stream, while remove_duplicates looks only at consecutive tokens, but other than that they are identical.

@jrodewig
Copy link
Copy Markdown
Contributor Author

@romseygeek Any feedback on this one? Thanks!

Copy link
Copy Markdown
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrodewig
Copy link
Copy Markdown
Contributor Author

Thanks @romseygeek!

@jrodewig jrodewig merged commit c99a0e9 into elastic:master Jan 28, 2020
@jrodewig jrodewig deleted the reformat.unique-token-filter branch January 28, 2020 15:33
jrodewig added a commit that referenced this pull request Jan 28, 2020
* Updates the description
* Adds analyze, custom analyzer, and custom filter snippets
* Adds parameter documentation
jrodewig added a commit that referenced this pull request Jan 28, 2020
* Updates the description
* Adds analyze, custom analyzer, and custom filter snippets
* Adds parameter documentation
jrodewig added a commit that referenced this pull request Jan 28, 2020
* Updates the description
* Adds analyze, custom analyzer, and custom filter snippets
* Adds parameter documentation
@jrodewig
Copy link
Copy Markdown
Contributor Author

Backport commits

master c99a0e9
7.x 70e4ae3
7.6 aec54a2
7.5 aa116a4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants