Fix NPE bug inner_hits#50709
Merged
mayya-sharipova merged 1 commit intoelastic:masterfrom Jan 7, 2020
Merged
Conversation
When there several subqueries on different relations of the join field, and only one of subqueries is using inner_hits, NPE occurs. This PR prevents NPE error. Closes elastic#50539
Collaborator
|
Pinging @elastic/es-search (:Search/Search) |
jimczi
approved these changes
Jan 7, 2020
Contributor
jimczi
left a comment
There was a problem hiding this comment.
LGTM, thanks @mayya-sharipova
mayya-sharipova
added a commit
that referenced
this pull request
Jan 7, 2020
When there several subqueries on different relations of the join field, and only one of subqueries is using inner_hits, NPE occurs. This PR prevents NPE error. Closes #50539
mayya-sharipova
added a commit
that referenced
this pull request
Jan 7, 2020
When there several subqueries on different relations of the join field, and only one of subqueries is using inner_hits, NPE occurs. This PR prevents NPE error. Closes #50539
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
When there several subqueries on different relations of the join field, and only one of subqueries is using inner_hits, NPE occurs. This PR prevents NPE error. Closes elastic#50539
This was referenced Feb 3, 2020
mayya-sharipova
added a commit
to mayya-sharipova/elasticsearch
that referenced
this pull request
Jul 20, 2021
This patch fixes test skip version, which was incorrect before. It also removes a duplicate index creation, as the index is already created during setup stage. Related to elastic#50709
mayya-sharipova
added a commit
that referenced
this pull request
Jul 20, 2021
This patch fixes test skip version, which was incorrect before. It also removes a duplicate index creation, as the index is already created during setup stage. Related to #50709
mayya-sharipova
added a commit
that referenced
this pull request
Jul 20, 2021
This patch fixes test skip version, which was incorrect before. It also removes a duplicate index creation, as the index is already created during setup stage. Related to #50709
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there several subqueries on different relations of the join field,
and only one of subqueries is using inner_hits, NPE occurs.
This PR prevents NPE error.
Closes #50539