[ML] Fix off-by-one error in ml_classic tokenizer end offset#50655
Merged
droberts195 merged 2 commits intoelastic:masterfrom Jan 7, 2020
Merged
[ML] Fix off-by-one error in ml_classic tokenizer end offset#50655droberts195 merged 2 commits intoelastic:masterfrom
droberts195 merged 2 commits intoelastic:masterfrom
Conversation
The end offset of a tokenizer is supposed to point one past the end of the input, not to the end character of the input. The ml_classic tokenizer was erroneously doing the latter.
Collaborator
|
Pinging @elastic/ml-core (:ml) |
Author
|
Jenkins run elasticsearch-ci/bwc |
Author
|
Jenkins run elasticsearch-ci/default-distro |
droberts195
added a commit
that referenced
this pull request
Jan 7, 2020
The end offset of a tokenizer is supposed to point one past the end of the input, not to the end character of the input. The ml_classic tokenizer was erroneously doing the latter.
7 tasks
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
…#50655) The end offset of a tokenizer is supposed to point one past the end of the input, not to the end character of the input. The ml_classic tokenizer was erroneously doing the latter.
This was referenced Feb 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The end offset of a tokenizer is supposed to point one past the
end of the input, not to the end character of the input. The
ml_classic tokenizer was erroneously doing the latter.