Skip to content

Correct condition for v7.5#50611

Merged
martijnvg merged 1 commit into7.5from
fkelbert-patch-1
Jan 14, 2020
Merged

Correct condition for v7.5#50611
martijnvg merged 1 commit into7.5from
fkelbert-patch-1

Conversation

@fkelbert
Copy link
Copy Markdown

@fkelbert fkelbert commented Jan 3, 2020

If I am not mistaken, then this change should be correctly reflecting how to compare the number of hits in 7.5.

Note: This is because Watcher defaults to "rest_total_hits_as_int" : true in 7.5.

If I am not mistaken, then this change should be correctly reflecting how to compare the number of hits in 7.5.
@fkelbert fkelbert added the >docs General docs changes label Jan 3, 2020
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Watcher)

fkelbert pushed a commit that referenced this pull request Jan 3, 2020
Also see #50611
This might need to be changed in other places as well.
Copy link
Copy Markdown
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martijnvg martijnvg merged commit 08e553c into 7.5 Jan 14, 2020
martijnvg pushed a commit that referenced this pull request Jan 14, 2020
martijnvg pushed a commit that referenced this pull request Jan 14, 2020
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
@colings86 colings86 deleted the fkelbert-patch-1 branch May 27, 2020 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Watcher >docs General docs changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants