Make EC2 Discovery Cache Empty Seed Hosts List#50607
Merged
original-brownbear merged 1 commit intoelastic:masterfrom Jan 3, 2020
original-brownbear:50550-follow-up
Merged
Make EC2 Discovery Cache Empty Seed Hosts List#50607original-brownbear merged 1 commit intoelastic:masterfrom original-brownbear:50550-follow-up
original-brownbear merged 1 commit intoelastic:masterfrom
original-brownbear:50550-follow-up
Conversation
Follow up to #50550. Cache empty nodes lists (`fetchDynamicNodes` will return an empty list in case of failure) now that the plugin properly retries requests to AWS EC2 APIs.
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Discovery-Plugins) |
DaveCTurner
approved these changes
Jan 3, 2020
Member
DaveCTurner
left a comment
There was a problem hiding this comment.
LGTM. I think we should mark this as a >bug.
Contributor
Author
|
Thanks David! |
original-brownbear
added a commit
that referenced
this pull request
Jan 3, 2020
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
Follow up to elastic#50550. Cache empty nodes lists (`fetchDynamicNodes` will return an empty list in case of failure) now that the plugin properly retries requests to AWS EC2 APIs.
This was referenced Feb 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #50550. Cache empty nodes lists (
fetchDynamicNodeswill return an empty list in case of failure) now that the plugin properly retries requests to AWS EC2 APIs.Note: I'd suggest adding tests for the exception handling once #50605 is in and we can add them cleanly by using a mocked REST APi instead of adding more actual mocking of AWS SDK classes for this.