ILM action to wait for SLM policy execution#50454
Merged
probakowski merged 28 commits intoelastic:masterfrom Jan 9, 2020
Merged
ILM action to wait for SLM policy execution#50454probakowski merged 28 commits intoelastic:masterfrom
probakowski merged 28 commits intoelastic:masterfrom
Conversation
This change add new ILM action to wait for SLM policy execution to ensure that index has snapshot before deletion. Closes elastic#45067.
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/ILM+SLM) |
dakrone
requested changes
Dec 20, 2019
Member
dakrone
left a comment
There was a problem hiding this comment.
Thanks for working on this @probakowski! I left some comments for you.
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ilm/WaitForSnapshotStep.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ilm/WaitForSnapshotStep.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ilm/WaitForSnapshotStep.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ilm/WaitForSnapshotStep.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ilm/WaitForSnapshotStep.java
Show resolved
Hide resolved
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ilm/SnapshotAction.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ilm/SnapshotAction.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/ilm/SnapshotActionTests.java
Outdated
Show resolved
Hide resolved
dakrone
approved these changes
Jan 3, 2020
Member
dakrone
left a comment
There was a problem hiding this comment.
LGTM, I left one comment. This also needs documentation to be added for the new action though, can you add that before merging this?
...lm/qa/multi-node/src/test/java/org/elasticsearch/xpack/ilm/TimeSeriesLifecycleActionsIT.java
Outdated
Show resolved
Hide resolved
dakrone
reviewed
Jan 8, 2020
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ilm/WaitForSnapshotAction.java
Outdated
Show resolved
Hide resolved
dakrone
reviewed
Jan 8, 2020
Co-Authored-By: Lee Hinman <dakrone@users.noreply.github.com>
probakowski
added a commit
to probakowski/elasticsearch
that referenced
this pull request
Jan 13, 2020
This change add new ILM action to wait for SLM policy execution to ensure that index has snapshot before deletion. Closes elastic#45067
probakowski
added a commit
that referenced
this pull request
Jan 14, 2020
* ILM action to wait for SLM policy execution (#50454) This change add new ILM action to wait for SLM policy execution to ensure that index has snapshot before deletion. Closes #45067 * Fix flaky TimeSeriesLifecycleActionsIT#testWaitForSnapshot test This change adds some randomness and cleanup step to TimeSeriesLifecycleActionsIT#testWaitForSnapshot and testWaitForSnapshotSlmExecutedBefore tests in attempt to make them stable. Reletes to #50781 * Formatting changes * Longer timeout * Fix Map.of in Java8 * Unused import removed
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
This change add new ILM action to wait for SLM policy execution to ensure that index has snapshot before deletion. Closes elastic#45067
This was referenced Feb 3, 2020
Collaborator
|
Pinging @elastic/es-ui (:ES-UI) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change add new ILM action to wait for SLM policy execution to ensure that index has snapshot before deletion.
Closes #45067.