Remove BlobContainer Tests against Mocks#50194
Merged
original-brownbear merged 2 commits intoelastic:masterfrom Dec 16, 2019
original-brownbear:better-s3-repo-tests
Merged
Remove BlobContainer Tests against Mocks#50194original-brownbear merged 2 commits intoelastic:masterfrom original-brownbear:better-s3-repo-tests
original-brownbear merged 2 commits intoelastic:masterfrom
original-brownbear:better-s3-repo-tests
Conversation
Removing all these weird mocks as asked for by #30424. All these tests are now part of real repository ITs and otherwise left unchanged if they had independent tests that didn't call the `createBlobStore` method previously. The HDFS tests also get added coverage as a side-effect because they did not have an implementation of the abstract repository ITs. Closes #30424
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
tlrx
approved these changes
Dec 16, 2019
Member
tlrx
left a comment
There was a problem hiding this comment.
LGTM! This is a long overdue work, thanks Armin! Also, nice stats :)
|
|
||
| @Override | ||
| protected Settings repositorySettings() { | ||
| assumeFalse("https://github.com/elastic/elasticsearch/issues/31498", HdfsRepositoryTests.isJava11()); |
Contributor
Author
|
Thanks Tanguy! :) |
original-brownbear
added a commit
that referenced
this pull request
Dec 16, 2019
* Remove BlobContainer Tests against Mocks Removing all these weird mocks as asked for by #30424. All these tests are now part of real repository ITs and otherwise left unchanged if they had independent tests that didn't call the `createBlobStore` method previously. The HDFS tests also get added coverage as a side-effect because they did not have an implementation of the abstract repository ITs. Closes #30424
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
* Remove BlobContainer Tests against Mocks Removing all these weird mocks as asked for by elastic#30424. All these tests are now part of real repository ITs and otherwise left unchanged if they had independent tests that didn't call the `createBlobStore` method previously. The HDFS tests also get added coverage as a side-effect because they did not have an implementation of the abstract repository ITs. Closes elastic#30424
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing all these weird mocks as asked for by #30424.
All these tests are now part of real repository ITs and otherwise left unchanged if they had
independent tests that didn't call the
createBlobStoremethod previously.The HDFS tests also get added coverage as a side-effect because they did not have an implementationof the abstract repository ITs.
This will allow us to more easily test different SDK versions because we don't have to support the complex blob store mocks removed here.
Closes #30424