Support "accept_enterprise" param in get license by tvernum · Pull Request #50067 · elastic/elasticsearch

tvernum · 2019-12-11T06:09:44Z

In 7.6 (#49474) we added an "accept_enterprise" parameter to the
GET _license endpoint.

This commit adds the same parameter to 8.0, except that
(a) it is deprecated
(b) the only acceptable value is "true"

This change also updates the license service to recognise 7.6 as a
supported cluster version for the enterprise license type.

In 7.6 (elastic#49474) we added an "accept_enterprise" parameter to the GET _license endpoint. This commit adds the same parameter to 8.0, except that (a) it is deprecated (b) the only acceptable value is "true" This change also updates the license service to recognise 7.6 as a supported cluster version for the enterprise license type.

elasticmachine · 2019-12-11T06:09:46Z

Pinging @elastic/es-security (:Security/License)

tvernum · 2019-12-11T06:10:33Z

@jkakavas I want to get this one reviewed so that I can merge it at the same time as #49474 (enterprise license for 7.x).

tvernum · 2019-12-11T06:44:16Z

java.lang.NullPointerException: no such build node: elasticsearch-ci-immutable-debian-10-1576044598081215110

@elasticmachine run elasticsearch-ci/bwc

jkakavas

LGTM

The release builds use a production license key, and our rest test load licenses that are signed by the dev license key. This change adds the new enterprise license Rest tests to the blacklist on release builds. Relates: elastic#50067 Resolves: elastic#50151

The release builds use a production license key, and our rest test load licenses that are signed by the dev license key. This change adds the new enterprise license Rest tests to the blacklist on release builds. Relates: #50067 Resolves: #50151

The release builds use a production license key, and our rest test load licenses that are signed by the dev license key. This change adds the new enterprise license Rest tests to the blacklist on release builds. Relates: elastic#50067 Resolves: elastic#50151 Backport of: elastic#50163

In 7.6 (elastic#49474) we added an "accept_enterprise" parameter to the GET _license endpoint. This commit adds the same parameter to 8.0, except that (a) it is deprecated (b) the only acceptable value is "true" This change also updates the license service to recognise 7.6 as a supported cluster version for the enterprise license type.

The release builds use a production license key, and our rest test load licenses that are signed by the dev license key. This change adds the new enterprise license Rest tests to the blacklist on release builds. Relates: elastic#50067 Resolves: elastic#50151

in elastic#50067 the accept_enterprise = false was no longer supported. This commit allows it under rest compatibility and ignores. in elastic#5073 there were changes when max_nodes and max_resource_units can exist. This does not require compatible changes as it feels to be behaviour change. Requires some testing transformation though relates elastic#51816

…es (#75479) in #50067 for _license the accept_enterprise = false was no longer supported. This commit allows it under rest compatibility and is showing enterprise licenses as platinum The same change had to be applied to _xpack endpoint #58217 in #50735 max_resource_units was introduced to be more accurate. For v7 requests, which do not know about enterprise license we will return max_node which will be set from max_resource_units (it assumes that one resource unit is 32GB - which corresponds to 1 node) relates #51816

…es (elastic#75479) in elastic#50067 for _license the accept_enterprise = false was no longer supported. This commit allows it under rest compatibility and is showing enterprise licenses as platinum The same change had to be applied to _xpack endpoint elastic#58217 in elastic#50735 max_resource_units was introduced to be more accurate. For v7 requests, which do not know about enterprise license we will return max_node which will be set from max_resource_units (it assumes that one resource unit is 32GB - which corresponds to 1 node) relates elastic#51816

This was added in 7.6, will be deprecated in 8.x, and removed in 9.x+ (noted in text). #50067

* document accept_enterprise parameter This was added in 7.6, will be deprecated in 8.x, and removed in 9.x+ (noted in text). #50067 * Update wording and deprecation notice * Incorporate review feedback Co-authored-by: Adam Locke <adam.locke@elastic.co>

* document accept_enterprise parameter This was added in 7.6, will be deprecated in 8.x, and removed in 9.x+ (noted in text). elastic#50067 * Update wording and deprecation notice * Incorporate review feedback Co-authored-by: Adam Locke <adam.locke@elastic.co>

* document accept_enterprise parameter This was added in 7.6, will be deprecated in 8.x, and removed in 9.x+ (noted in text). #50067 * Update wording and deprecation notice * Incorporate review feedback Co-authored-by: Adam Locke <adam.locke@elastic.co> Co-authored-by: Ken MacInnis <ken.macinnis@elastic.co>

* document accept_enterprise parameter This was added in 7.6, will be deprecated in 8.x, and removed in 9.x+ (noted in text). elastic#50067 * Update wording and deprecation notice * Incorporate review feedback Co-authored-by: Adam Locke <adam.locke@elastic.co> Co-authored-by: Ken MacInnis <ken.macinnis@elastic.co>

…lastic#79256) * document accept_enterprise parameter This was added in 7.6, will be deprecated in 8.x, and removed in 9.x+ (noted in text). elastic#50067 * Update wording and deprecation notice * Incorporate review feedback Co-authored-by: Adam Locke <adam.locke@elastic.co> Co-authored-by: Ken MacInnis <ken.macinnis@elastic.co>

* document accept_enterprise parameter This was added in 7.6, will be deprecated in 8.x, and removed in 9.x+ (noted in text). #50067 * Update wording and deprecation notice * Incorporate review feedback Co-authored-by: Adam Locke <adam.locke@elastic.co> Co-authored-by: Ken MacInnis <ken.macinnis@elastic.co> Co-authored-by: Ken MacInnis <ken.macinnis@elastic.co>

…79267) * document accept_enterprise parameter This was added in 7.6, will be deprecated in 8.x, and removed in 9.x+ (noted in text). #50067 * Update wording and deprecation notice * Incorporate review feedback Co-authored-by: Adam Locke <adam.locke@elastic.co> Co-authored-by: Ken MacInnis <ken.macinnis@elastic.co> Co-authored-by: Ken MacInnis <ken.macinnis@elastic.co>

tvernum added >enhancement :Security/License License functionality for commercial features v8.0.0 labels Dec 11, 2019

tvernum requested a review from jkakavas December 11, 2019 06:09

jkakavas approved these changes Dec 11, 2019

View reviewed changes

tvernum merged commit 9a781c6 into elastic:master Dec 12, 2019

tvernum mentioned this pull request Dec 13, 2019

Skip enterprise license tests in release build #50163

Merged

pgomulka mentioned this pull request Jul 19, 2021

[Rest Api Compatibility] Licence accept_enterprise and response changes #75479

Merged

jakelandis added v8.0.0-alpha1 and removed v8.0.0 labels Jul 26, 2021

kcm pushed a commit that referenced this pull request Oct 12, 2021

document accept_enterprise parameter

506549e

This was added in 7.6, will be deprecated in 8.x, and removed in 9.x+ (noted in text). #50067

kcm mentioned this pull request Oct 12, 2021

document accept_enterprise parameter #79012

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support "accept_enterprise" param in get license#50067

Support "accept_enterprise" param in get license#50067
tvernum merged 1 commit intoelastic:masterfrom
tvernum:enterprise-license/accept_enterprise_8x

tvernum commented Dec 11, 2019

Uh oh!

elasticmachine commented Dec 11, 2019

Uh oh!

tvernum commented Dec 11, 2019

Uh oh!

tvernum commented Dec 11, 2019

Uh oh!

jkakavas left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

tvernum commented Dec 11, 2019

Uh oh!

elasticmachine commented Dec 11, 2019

Uh oh!

tvernum commented Dec 11, 2019

Uh oh!

tvernum commented Dec 11, 2019

Uh oh!

jkakavas left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants