Cleanup Old index-N Blobs in Repository Cleanup#49862
Cleanup Old index-N Blobs in Repository Cleanup#49862original-brownbear merged 2 commits intoelastic:masterfrom original-brownbear:enhance-repo-cleanup
Conversation
Repository cleanup didn't deal with old index-N, this change adds cleaning up all old index-N found in the repository.
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
tlrx
left a comment
There was a problem hiding this comment.
LGTM - left minor comment about log traces that I don't find very useful and fills the test execution logs
| internalCluster().startNodes(Settings.EMPTY); | ||
|
|
||
| final String repoName = "test-repo"; | ||
| logger.info("--> creating repository"); |
There was a problem hiding this comment.
I'm not sure such info logs are very helpful
There was a problem hiding this comment.
I gotta disagree here :) I find these super helpful when it comes to debugging test failures from uncaught exceptions (esp. failing asserts on some non-test thread) where without these you often have a very hard time figuring out where exactly you were in the test at the time of the failure.
I wonder if we could do a better job on the logging side though ... there's not much point actually logging this stuff to the output on passing tests (basically like we have on the CLI). We could bring that up with core/infra?
|
Thanks Tanguy! Let's look into a better approach to logging elsewhere IMO, hope you don't mind :) |
* Cleanup Old index-N Blobs in Repository Cleanup Repository cleanup didn't deal with old index-N, this change adds cleaning up all old index-N found in the repository. * add test
Repository cleanup didn't deal with outdated index-N at the repository root, this change adds
cleaning up old index-N found in the repository.