Interval queries cannot be cached if they use scripts#49824
Merged
romseygeek merged 2 commits intoelastic:masterfrom Dec 4, 2019
Merged
Interval queries cannot be cached if they use scripts#49824romseygeek merged 2 commits intoelastic:masterfrom
romseygeek merged 2 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-search (:Search/Search) |
Contributor
Author
|
@elasticmachine update branch |
pugnascotia
reviewed
Dec 4, 2019
Contributor
pugnascotia
left a comment
There was a problem hiding this comment.
Looks good, but I'm not familiar with what this code does so I'll defer to someone in the Search team.
romseygeek
added a commit
that referenced
this pull request
Dec 4, 2019
not adjust testCacheability(), which how fails occasionally when given a random interval source containing a script. This commit overrides testCacheability() to explicitly sources with and without script filters. Fixes #49821
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
…9824) elastic#49793 added test coverage for interval queries that contain script filters, but did not adjust testCacheability(), which how fails occasionally when given a random interval source containing a script. This commit overrides testCacheability() to explicitly sources with and without script filters. Fixes elastic#49821
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#49793 added test coverage for interval queries that contain script filters, but did
not adjust
testCacheability(), which how fails occasionally when given a randominterval source containing a script. This commit overrides
testCacheability()toexplicitly sources with and without script filters.
Fixes #49821