Improve coverage of equals/hashCode tests for IntervalQueryBuilder#49820
Merged
romseygeek merged 3 commits intoelastic:masterfrom Dec 4, 2019
Merged
Improve coverage of equals/hashCode tests for IntervalQueryBuilder#49820romseygeek merged 3 commits intoelastic:masterfrom
romseygeek merged 3 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-search (:Search/Search) |
cbuescher
approved these changes
Dec 4, 2019
Member
cbuescher
left a comment
There was a problem hiding this comment.
Thanks for adding this, LGTM.
romseygeek
added a commit
that referenced
this pull request
Dec 4, 2019
…49820) By default, AbstractQueryTestCase only changes name and boost in its mutateInstance method, used when checking equals and hashcode implementations. This commit adds a mutateInstance method to InveralQueryBuilderTests that will check hashcode and equality when the field or intervals source are changed.
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
…lastic#49820) By default, AbstractQueryTestCase only changes name and boost in its mutateInstance method, used when checking equals and hashcode implementations. This commit adds a mutateInstance method to InveralQueryBuilderTests that will check hashcode and equality when the field or intervals source are changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, AbstractQueryTestCase only changes name and boost in its mutateInstance
method, used when checking equals and hashcode implementations. This commit adds
a mutateInstance method to InveralQueryBuilderTests that will check hashcode and
equality when the field or intervals source are changed.