Merged
Conversation
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Core) |
Member
|
@pgomulka Can you please look through the changelog from 2.10.1 to 2.10.5 to see if there is anything alarming? If not it would seem good to get this in, especially since you are adding better backcompat support with joda formats in 7.x. |
Contributor
|
it looks safe to me. We already use 2.10.5 so I consider this tested. the only change of behaviour we could notice would be with fixing |
pgomulka
pushed a commit
to pgomulka/elasticsearch
that referenced
this pull request
May 7, 2020
pgomulka
pushed a commit
to pgomulka/elasticsearch
that referenced
this pull request
May 7, 2020
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
May 26, 2020
This reverts commit f2369f6.
pgomulka
added a commit
that referenced
this pull request
May 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is merely up for discussion. As the joda dependency is in maintenance mode, that main reasons for upgrading are bugs (rather rare) and an update of the timezone database. This is also the reason why I think we should update joda on 6.8, as this needs to be maintained for some time and timezone changes are important to follow through.
The reason for this issue is a forum post with a timezone change from this year (Brazil banning DST), that is only in this years timezone database, the current joda time release in 6.8 however is from 2018. See https://discuss.elastic.co/t/wrong-timezone-in-painless-function/209905/3