Fix LOCATE function optional parameter handling #49666
Merged
astefan merged 2 commits intoelastic:masterfrom Dec 2, 2019
Merged
Fix LOCATE function optional parameter handling #49666astefan merged 2 commits intoelastic:masterfrom
astefan merged 2 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-search (:Search/SQL) |
astefan
added a commit
to astefan/elasticsearch
that referenced
this pull request
Dec 2, 2019
(cherry picked from commit dd3aeb8)
astefan
added a commit
that referenced
this pull request
Dec 3, 2019
(cherry picked from commit dd3aeb8)
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
This was referenced Feb 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the optional parameter handling in case LOCATE function received as parameters other functions that made its Node to have its children transformed. During this transformation step, the optional parameter was never accounted for.
Fixes #49557.