Remove ClassInfo interface and BinaryClassInfo class.#49649
Merged
przemekwitek merged 3 commits intoelastic:masterfrom Nov 28, 2019
Merged
Remove ClassInfo interface and BinaryClassInfo class.#49649przemekwitek merged 3 commits intoelastic:masterfrom
przemekwitek merged 3 commits intoelastic:masterfrom
Conversation
7ddc3f9 to
ba5e55d
Compare
Collaborator
|
Pinging @elastic/ml-core (:ml) |
Author
|
run elasticsearch-ci/default-distro |
1 similar comment
Author
|
run elasticsearch-ci/default-distro |
Contributor
dimitris-athanasiou
left a comment
There was a problem hiding this comment.
Lots of good stuff in this one! My two code comments are very minor and on points you didn't introduce now but it was already in the existing code.
...ugin/core/src/main/java/org/elasticsearch/xpack/core/ml/dataframe/evaluation/Evaluation.java
Outdated
Show resolved
Hide resolved
...ugin/core/src/main/java/org/elasticsearch/xpack/core/ml/dataframe/evaluation/Evaluation.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several cleanups in evaluation server-side code:
ClassInfointerface andBinaryClassInfoclass. This class was meant to provide support for multiple classes but such a functionality is not currently needed and the code becomes simpler without it.aggsandprocessmethods toEvaluationMetricinterfaceEvaluation's subclasses to the interfaceRelated to #48759