Improve Stability of GCS Mock API#49592
Merged
original-brownbear merged 1 commit intoelastic:masterfrom Nov 26, 2019
original-brownbear:stabilize-gcs-mock
Merged
Improve Stability of GCS Mock API#49592original-brownbear merged 1 commit intoelastic:masterfrom original-brownbear:stabilize-gcs-mock
original-brownbear merged 1 commit intoelastic:masterfrom
original-brownbear:stabilize-gcs-mock
Conversation
Same as #49518 pretty much but for GCS. Fixing a few more spots where input stream can get closed without being fully drained and adding assertions to make sure it's always drained. Moved the no-close stream wrapper to production code utilities since there's a number of spots in production code where it's also useful (will reuse it there in a follow-up).
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
| exchange.getResponseHeaders().add("Content-Type", "application/json"); | ||
| exchange.sendResponseHeaders(RestStatus.OK.getStatus(), response.length); | ||
| exchange.getResponseBody().write(response); | ||
| while (exchange.getRequestBody().read(BUFFER) >= 0) ; |
Contributor
Author
There was a problem hiding this comment.
We were actually failing the assertion here since this request's body isn't empty.
Contributor
Author
|
@tlrx this cleans up all the unexpected EOF exceptions in the GCS tests I think. I ran tests in a loop with a breakpoint at |
Contributor
Author
|
Thanks Tanguy! |
This was referenced Nov 26, 2019
original-brownbear
added a commit
that referenced
this pull request
Nov 26, 2019
Same as #49518 pretty much but for GCS. Fixing a few more spots where input stream can get closed without being fully drained and adding assertions to make sure it's always drained. Moved the no-close stream wrapper to production code utilities since there's a number of spots in production code where it's also useful (will reuse it there in a follow-up).
original-brownbear
added a commit
that referenced
this pull request
Nov 26, 2019
Same as #49518 pretty much but for GCS. Fixing a few more spots where input stream can get closed without being fully drained and adding assertions to make sure it's always drained. Moved the no-close stream wrapper to production code utilities since there's a number of spots in production code where it's also useful (will reuse it there in a follow-up).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #49518 pretty much but for GCS.
Fixing a few more spots where input stream can get closed
without being fully drained and adding assertions to make sure
it's always drained.
Moved the no-close stream wrapper to production code utilities since
there's a number of spots in production code where it's also useful
(will reuse it there in a follow-up).