Skip to content

Avoid double-wrapping allocator#49534

Merged
ywelsch merged 1 commit intoelastic:masterfrom
ywelsch:double-wrap-allocator
Nov 27, 2019
Merged

Avoid double-wrapping allocator#49534
ywelsch merged 1 commit intoelastic:masterfrom
ywelsch:double-wrap-allocator

Conversation

@ywelsch
Copy link
Copy Markdown
Contributor

@ywelsch ywelsch commented Nov 25, 2019

When using unpooled, the allocator is wrapped twice in a NoDirectBuffers.

@ywelsch ywelsch added >non-issue :Distributed/Network Http and internode communication implementations v8.0.0 v7.6.0 v7.5.1 labels Nov 25, 2019
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-distributed (:Distributed/Network)

Copy link
Copy Markdown
Contributor

@original-brownbear original-brownbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Copy link
Copy Markdown
Contributor

@Tim-Brooks Tim-Brooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ywelsch
Copy link
Copy Markdown
Contributor Author

ywelsch commented Nov 26, 2019

@elasticmachine run elasticsearch-ci/2

@ywelsch ywelsch merged commit 403b938 into elastic:master Nov 27, 2019
ywelsch added a commit that referenced this pull request Nov 27, 2019
When using unpooled, the allocator is wrapped twice in a NoDirectBuffers.
ywelsch added a commit that referenced this pull request Nov 27, 2019
When using unpooled, the allocator is wrapped twice in a NoDirectBuffers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Network Http and internode communication implementations >non-issue v7.5.1 v7.6.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants