[ML] Apply source query on data frame analytics memory estimation#49517
Merged
dimitris-athanasiou merged 3 commits intoelastic:masterfrom Nov 25, 2019
Conversation
Collaborator
|
Pinging @elastic/ml-core (:ml) |
przemekwitek
approved these changes
Nov 25, 2019
przemekwitek
left a comment
There was a problem hiding this comment.
LGTM
Two minor comments inline.
...-tests/src/test/java/org/elasticsearch/xpack/ml/integration/ExplainDataFrameAnalyticsIT.java
Outdated
Show resolved
Hide resolved
|
|
||
| ExplainDataFrameAnalyticsAction.Response explainResponse = explainDataFrame(config); | ||
|
|
||
| assertThat(explainResponse.getMemoryEstimation().getExpectedMemoryWithoutDisk().getKb(), lessThanOrEqualTo(500L)); |
There was a problem hiding this comment.
I'm wondering if
assertThat(explainResponse.getMemoryEstimation().getExpectedMemoryWithoutDisk(), lessThanOrEqualTo(new ByteSizeValue(500, KB)));
would work as well.
Contributor
Author
There was a problem hiding this comment.
It does but it makes the line longer and I don't think it significantly improves readability.
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
Nov 25, 2019
dimitris-athanasiou
added a commit
that referenced
this pull request
Nov 25, 2019
Contributor
|
@dimitris-athanasiou FYI I'm removing the |
This was referenced Feb 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #49454