Stop timing stats failure propagation#49495
Merged
benwtrent merged 1 commit intoelastic:masterfrom Nov 22, 2019
Merged
Conversation
Collaborator
|
Pinging @elastic/ml-core (:ml) |
This was referenced Nov 22, 2019
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Nov 22, 2019
przemekwitek
left a comment
There was a problem hiding this comment.
LGTM
Thanks for fixing that, Ben!
benwtrent
added a commit
that referenced
this pull request
Nov 25, 2019
benwtrent
added a commit
that referenced
this pull request
Dec 3, 2019
This was referenced Feb 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Timestats failures can cause issues for datafeeds in places other than stop. Example: Initial query/scroll. If persisting the search time fails, the datafeed treats that as a failure and stops.
We should continue executing through stats persistence failures and log if a failure occurs.