Skip to content

Support es7 node http publish_address format#49279

Merged
jbaiera merged 3 commits intoelastic:masterfrom
zacharymorn:issue-48950
Dec 4, 2019
Merged

Support es7 node http publish_address format#49279
jbaiera merged 3 commits intoelastic:masterfrom
zacharymorn:issue-48950

Conversation

@zacharymorn
Copy link
Copy Markdown
Contributor

@zacharymorn zacharymorn commented Nov 19, 2019

Add parsing support to es7 node http publish_address format cname/ip:port. For details, please refers to #48950

@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Nov 19, 2019

Pinging @elastic/es-core-features (:Core/Features/Java High Level REST Client)

@jakelandis jakelandis requested a review from jbaiera November 21, 2019 15:41
@msimos
Copy link
Copy Markdown

msimos commented Nov 21, 2019

Is there any plans to add this to 7.x? We're seeing other people in the field with this issue.

@UglyBarnacle
Copy link
Copy Markdown

UglyBarnacle commented Nov 24, 2019

this should be definitely be included to 7.x because it originates from there: 7.x client nodesniffer not being able to read the newly introduced format of publich_address in 7.0.
Maybe should even backported to 6.8, where the new style format was already showed as deprecation warning

@zacharymorn zacharymorn reopened this Nov 25, 2019
@zacharymorn
Copy link
Copy Markdown
Contributor Author

zacharymorn commented Nov 25, 2019

I also feel that this fix should be back ported to earlier versions as well. As I'm new to contributing to ES, am I expected to perform back porting as well by submitting more PRs, or the project maintainer will take care of that?

@jbaiera
Copy link
Copy Markdown
Member

jbaiera commented Dec 2, 2019

@zacharymorn no worries about backports. Whoever performs the review/merging of the PR will handle any backport work.

jbaiera
jbaiera requested changes Dec 3, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@jbaiera jbaiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience over the recent US holiday week. Looks good. Just one request regarding changing the domain name used in the test.

@zacharymorn zacharymorn requested a review from jbaiera December 4, 2019 04:09
jbaiera
jbaiera reviewed Dec 4, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@jbaiera jbaiera left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

@jbaiera
Copy link
Copy Markdown
Member

jbaiera commented Dec 4, 2019

@elasticmachine ok to test

@jbaiera
Copy link
Copy Markdown
Member

jbaiera commented Dec 4, 2019

@elasticmachine update branch

@jbaiera
Copy link
Copy Markdown
Member

jbaiera commented Dec 4, 2019

@elasticmachine run elasticsearch-ci/2

jbaiera
jbaiera approved these changes Dec 4, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@jbaiera jbaiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR

@jbaiera jbaiera merged commit bbbdf94 into elastic:master Dec 4, 2019
@jbaiera jbaiera mentioned this pull request Dec 4, 2019
Merged
jbaiera pushed a commit to jbaiera/elasticsearch that referenced this pull request Dec 4, 2019
@zacharymorn @jbaiera
Support es7 node http publish_address format (elastic#49279)
70af072 
Add parsing support to node http publish_address format cname/ip:port.
@jbaiera jbaiera mentioned this pull request Dec 4, 2019
Merged
jbaiera pushed a commit to jbaiera/elasticsearch that referenced this pull request Dec 4, 2019
@zacharymorn @jbaiera
Support es7 node http publish_address format (elastic#49279)
b8378b7 
Add parsing support to node http publish_address format cname/ip:port.
@jbaiera jbaiera mentioned this pull request Dec 4, 2019
Merged
jbaiera pushed a commit to jbaiera/elasticsearch that referenced this pull request Dec 4, 2019
@zacharymorn @jbaiera
Support es7 node http publish_address format (elastic#49279)
8ef55a6 
Add parsing support to node http publish_address format cname/ip:port.
jbaiera added a commit that referenced this pull request Dec 5, 2019
@jbaiera
Support es7 node http publish_address format (#49279) (#49839)
1d97cee 
Add parsing support to node http publish_address format cname/ip:port.
jbaiera added a commit that referenced this pull request Dec 5, 2019
@jbaiera
Support es7 node http publish_address format (#49279) (#49841)
db34ce2 
Add parsing support to node http publish_address format cname/ip:port.
jbaiera added a commit that referenced this pull request Dec 5, 2019
@jbaiera
Support es7 node http publish_address format (#49279) (#49843)
9a1bde2 
Add parsing support to node http publish_address format cname/ip:port.
@jrodewig jrodewig mentioned this pull request Dec 14, 2019
Closed
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
@zacharymorn @SivagurunathanV
Support es7 node http publish_address format (elastic#49279)
ba453c7 
Add parsing support to node http publish_address format cname/ip:port.
This was referenced Feb 3, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbaiera jbaiera jbaiera approved these changes

Assignees

No one assigned

Labels

>bug v6.8.6 v7.5.1 v7.6.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@zacharymorn @elasticmachine @msimos @UglyBarnacle @jbaiera @jakelandis @cbuescher