[ML][Inference] Fixing pre-processor value handling and size estimate#49270
Merged
benwtrent merged 2 commits intoelastic:masterfrom Nov 22, 2019
Merged
Conversation
Collaborator
|
Pinging @elastic/ml-core (:ml) |
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Nov 22, 2019
…elastic#49270) * [ML][Inference] Fixing pre-processor value handling and size estimate * fixing npe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug right now when handling numerics that are treated as categorical values. This is a valid use as encoding semi-ordinal numbers
10, 50, 5000categorically can improve model performance instead of simply treating them as numerics.Additionally, when estimating the size of the pre-processor HashMaps,
Doubleentries were estimated with the default value of256when it should have been a simpleshallowSizeOf. SettingdefSizein thesizeOfMapto0corrects this.