Ignore Lucene index in peer recovery if translog corrupted#49114
Merged
dnhatn merged 3 commits intoelastic:masterfrom Nov 18, 2019
Merged
Ignore Lucene index in peer recovery if translog corrupted#49114dnhatn merged 3 commits intoelastic:masterfrom
dnhatn merged 3 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Recovery) |
Member
Author
|
An alternative is to mark the store as corrupted if we failed to locally recover up to the global checkpoint. But it seems harsh, and we also need to handle a situation where we failed to mark the store as corrupted. |
Member
Author
|
run elasticsearch-ci/1 |
Member
Author
|
Thanks Yannick and Henning. |
dnhatn
added a commit
that referenced
this pull request
Nov 20, 2019
If the translog on a replica is corrupt, we should not perform an operation-based recovery or utilize sync_id as we won't be able to open an engine in the next step. This change adds an extra validation that ensures translog is okay when preparing a peer recovery request.
dnhatn
added a commit
that referenced
this pull request
Nov 24, 2019
If the translog on a replica is corrupt, we should not perform an operation-based recovery or utilize sync_id as we won't be able to open an engine in the next step. This change adds an extra validation that ensures translog is okay when preparing a peer recovery request.
dnhatn
added a commit
that referenced
this pull request
Nov 24, 2019
If the translog on a replica is corrupt, we should not perform an operation-based recovery or utilize sync_id as we won't be able to open an engine in the next step. This change adds an extra validation that ensures translog is okay when preparing a peer recovery request.
dnhatn
added a commit
that referenced
this pull request
Nov 25, 2019
If the translog on a replica is corrupt, we should not perform an operation-based recovery or utilize sync_id as we won't be able to open an engine in the next step. This change adds an extra validation that ensures translog is okay when preparing a peer recovery request.
|
before this patch, peer recovery maybe occur a exception like this: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the translog on a replica is corrupt, we should not perform an operation-based recovery or utilize sync_id as we won't be able to open an engine in the next step. This change adds an extra validation that ensures translog is okay when preparing a peer recovery request.