SQL: [Tests] Mute testReplaceChildren for Pivot#49045
Merged
matriv merged 1 commit intoelastic:masterfrom Nov 14, 2019
Merged
Conversation
Temporarily "mute" the testReplaceChildren for Pivot since it leads to failing tests for some seeds, since the new child doesn't respond to a valid data type. Relates to elastic#48900
Collaborator
|
Pinging @elastic/es-search (:Search/SQL) |
Contributor
Author
|
Re-opening this, since the proper fix needs more work. |
costin
approved these changes
Nov 14, 2019
matriv
added a commit
that referenced
this pull request
Nov 14, 2019
matriv
added a commit
that referenced
this pull request
Nov 14, 2019
matriv
added a commit
to matriv/elasticsearch
that referenced
this pull request
Dec 6, 2019
The `testReplaceChildren()` has been fixed for Pivot as part of elastic#49693. Reverting: elastic#49045
matriv
added a commit
that referenced
this pull request
Dec 9, 2019
matriv
added a commit
that referenced
this pull request
Dec 9, 2019
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
The `testReplaceChildren()` has been fixed for Pivot as part of elastic#49693. Reverting: elastic#49045
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporarily "mute" the testReplaceChildren for Pivot since it leads to
failing tests for some seeds, since the new child doesn't respond to a
valid data type.
Relates to #48900